From 1caf3fdb0cc9a09624fdf213651e0e36e68e9f4c Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Sat, 29 Nov 2025 18:13:37 -0800 Subject: [PATCH] remove temporary markdown file (#7048) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Deletes a file accidentally committed when rebasing and doing `git add .` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7048-remove-temporary-markdown-file-2bb6d73d36508139b95ef3c7e4ab0798) by [Unito](https://www.unito.io) --- cloud-loader-dropdown.md | 24 ------------------------ 1 file changed, 24 deletions(-) delete mode 100644 cloud-loader-dropdown.md diff --git a/cloud-loader-dropdown.md b/cloud-loader-dropdown.md deleted file mode 100644 index 84ef26385..000000000 --- a/cloud-loader-dropdown.md +++ /dev/null @@ -1,24 +0,0 @@ -Fixes loader dropdown placeholder -=============================== - -Cloud loader dropdowns hydrate via `useAssetWidgetData(nodeType)`, so `dropdownItems` stays empty until the Asset API returns friendly filenames. Meanwhile `modelValue` already holds the saved asset and the watcher at [WidgetSelectDropdown.vue#L215-L227](https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue#L215-L227) only tracks `modelValue`. It runs before assets load, fails to find a match, clears `selectedSet`, and the placeholder persists. - -```ts -watch( - modelValue, - (currentValue) => { - if (currentValue === undefined) { - selectedSet.value.clear() - return - } - const item = dropdownItems.value.find((item) => item.name === currentValue) - if (item) { - selectedSet.value.clear() - selectedSet.value.add(item.id) - } - }, - { immediate: true } -) -``` - -Once the API resolves, `dropdownItems` recomputes but nothing resyncs because the watcher never sees that change. Desktop doesn’t hit this because it still reads from `widget.options.values` immediately.