Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-03-07 22:20:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add unicorn lint rules - DOM built-in functions (#628)

Browse Source 
- Prefer append(), remove(), replaceAll()
- Wrap nested ternaries in parenthesis
This commit is contained in:
filtered
2025-02-27 20:18:25 +11:00
committed by GitHub
parent 6f51767451
commit 1e8938ceff
11 changed files with 60 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/LiteGraphGlobal.ts
View File

@@ -552,8 +552,8 @@ export class LiteGraphGlobal {
const dynamicScript = document.createElement("script")
dynamicScript.type = "text/javascript"
dynamicScript.src = src
docHeadObj.appendChild(dynamicScript)
docHeadObj.removeChild(script_file)
docHeadObj.append(dynamicScript)
script_file.remove()
} catch (err) {
if (this.throw_errors) throw err
if (this.debug) console.log("Error while reloading " + src)
@@ -583,7 +583,7 @@ export class LiteGraphGlobal {
*/
uuidv4(): string {
// @ts-ignore
return ([1e7] + -1e3 + -4e3 + -8e3 + -1e11).replace(/[018]/g, a =>
return ([1e7] + -1e3 + -4e3 + -8e3 + -1e11).replaceAll(/[018]/g, a =>
(a ^ ((Math.random() * 16) >> (a / 4))).toString(16))
}
@@ -632,12 +632,12 @@ export class LiteGraphGlobal {
// used to create nodes from wrapping functions
getParameterNames(func: (...args: any) => any): string[] {
return (func + "")
.replace(/\/\/.*$/gm, "") // strip single-line comments
.replace(/\s+/g, "") // strip white space
.replace(/\/\*[^*/]*\*\//g, "") // strip multi-line comments /**/
.replaceAll(/\/\/.*$/gm, "") // strip single-line comments
.replaceAll(/\s+/g, "") // strip white space
.replaceAll(/\/\*[^*/]*\*\//g, "") // strip multi-line comments /**/
.split("){", 1)[0]
.replace(/^[^(]*\(/, "") // extract the parameters
.replace(/=[^,]+/g, "") // strip any ES6 defaults
.replaceAll(/=[^,]+/g, "") // strip any ES6 defaults
.split(",")
.filter(Boolean) // split & filter [""]
}
@@ -836,7 +836,7 @@ export class LiteGraphGlobal {
if ("close" in result && typeof result.close === "function") {
result.close()
} else if (result.parentNode) {
result.parentNode.removeChild(result)
result.remove()
}
}
}