From 1ef3c007e6e6c96f4b91fc4b5f09d6c1c230baef Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 7 May 2025 09:03:23 -0700 Subject: [PATCH] [Auth] Allow user select GitHub account on login (#3801) --- src/stores/firebaseAuthStore.ts | 3 +++ tests-ui/tests/store/firebaseAuthStore.test.ts | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/stores/firebaseAuthStore.ts b/src/stores/firebaseAuthStore.ts index 32d81d84f..9fedc19b6 100644 --- a/src/stores/firebaseAuthStore.ts +++ b/src/stores/firebaseAuthStore.ts @@ -60,6 +60,9 @@ export const useFirebaseAuthStore = defineStore('firebaseAuth', () => { prompt: 'select_account' }) const githubProvider = new GithubAuthProvider() + githubProvider.setCustomParameters({ + prompt: 'select_account' + }) // Getters const isAuthenticated = computed(() => !!currentUser.value) diff --git a/tests-ui/tests/store/firebaseAuthStore.test.ts b/tests-ui/tests/store/firebaseAuthStore.test.ts index a54592fd3..7d51685b4 100644 --- a/tests-ui/tests/store/firebaseAuthStore.test.ts +++ b/tests-ui/tests/store/firebaseAuthStore.test.ts @@ -55,7 +55,9 @@ vi.mock('firebase/auth', () => ({ GoogleAuthProvider: class { setCustomParameters = vi.fn() }, - GithubAuthProvider: vi.fn(), + GithubAuthProvider: class { + setCustomParameters = vi.fn() + }, browserLocalPersistence: 'browserLocalPersistence', setPersistence: vi.fn().mockResolvedValue(undefined) }))