Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-28 10:12:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add TS types - API (#1736)

Browse Source 
* nit

* Add TS types - API events

* Replace all API event emits with type-safe variants

* Add missing API type

* nit

* Remove test code, nit
This commit is contained in:
filtered
2024-11-30 05:15:25 +11:00
committed by GitHub
parent 0bf30e7621
commit 2017b9016b
8 changed files with 225 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
tests-ui/tests/slow/groupNode.test.ts
View File

@@ -362,7 +362,7 @@ describe('group node', () => {
const { ez, graph, app } = await start()
const nodes = createDefaultWorkflow(ez, graph)
let reroutes: EzNode[] = []
const reroutes: EzNode[] = []
let prevNode = nodes.ckpt
for (let i = 0; i < 5; i++) {
const reroute = ez.Reroute()
@@ -568,37 +568,23 @@ describe('group node', () => {
const { api } = await import('../../../src/scripts/api')
api.dispatchEvent(new CustomEvent('execution_start', {}))
api.dispatchEvent(
new CustomEvent('executing', { detail: `${nodes.save.id}` })
)
api.dispatchCustomEvent('execution_start', undefined)
api.dispatchCustomEvent('executing', `${nodes.save.id}`)
// Event should be forwarded to group node id
expect(group.node['imgs']).toBeFalsy()
api.dispatchEvent(
new CustomEvent('executed', {
detail: {
node: `${nodes.save.id}`,
display_node: `${nodes.save.id}`,
output: {
images: [
{
filename: 'test.png',
type: 'output'
}
]
}
}
})
)
api.dispatchCustomEvent('executed', {
node: `${nodes.save.id}`,
display_node: `${nodes.save.id}`,
output: {
images: [{ filename: 'test.png', type: 'output' }]
}
})
// Trigger paint
group.node.onDrawBackground?.(app.canvas.ctx, app.canvas.canvas)
expect(group.node['images']).toEqual([
{
filename: 'test.png',
type: 'output'
}
{ filename: 'test.png', type: 'output' }
])
// Reload
@@ -610,26 +596,17 @@ describe('group node', () => {
group.node['getInnerNodes']()
// Check it works for internal node ids
api.dispatchEvent(new CustomEvent('execution_start', {}))
api.dispatchEvent(new CustomEvent('executing', { detail: `${group.id}:5` }))
api.dispatchCustomEvent('execution_start', undefined)
api.dispatchCustomEvent('executing', `${group.id}:5`)
// Event should be forwarded to group node id
expect(group.node['imgs']).toBeFalsy()
api.dispatchEvent(
new CustomEvent('executed', {
detail: {
node: `${group.id}:5`,
display_node: `${group.id}:5`,
output: {
images: [
{
filename: 'test2.png',
type: 'output'
}
]
}
}
})
)
api.dispatchCustomEvent('executed', {
node: `${group.id}:5`,
display_node: `${group.id}:5`,
output: {
images: [{ filename: 'test2.png', type: 'output' }]
}
})
// Trigger paint
group.node.onDrawBackground?.(app.canvas.ctx, app.canvas.canvas)
@@ -791,7 +768,7 @@ describe('group node', () => {
})
expect(dialogShow).toBeCalledTimes(1)
// @ts-expect-error
// @ts-expect-error Mocked
const call = dialogShow.mock.calls[0][0].innerHTML
expect(call).toContain('the following node types were not found')
expect(call).toContain('NotKSampler')