From 203696f2f986414ef7314c4fa1229a4bbca36638 Mon Sep 17 00:00:00 2001 From: Austin Mroz Date: Sat, 28 Mar 2026 20:44:05 -0700 Subject: [PATCH] Further begrudged fixture migration --- browser_tests/fixtures/helpers/AppModeHelper.ts | 6 ++++++ browser_tests/tests/appMode.spec.ts | 14 +++++--------- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/browser_tests/fixtures/helpers/AppModeHelper.ts b/browser_tests/fixtures/helpers/AppModeHelper.ts index ebc1d8696f..ff132a470d 100644 --- a/browser_tests/fixtures/helpers/AppModeHelper.ts +++ b/browser_tests/fixtures/helpers/AppModeHelper.ts @@ -89,6 +89,9 @@ export class AppModeHelper { get mobileView(): Locator { return this.page.getByTestId(TestIds.linear.mobile) } + get mobileNavigation(): Locator { + return this.page.getByRole('tablist').filter({ hasText: 'Run' }) + } get mobileWorkflows() { return this.mobileView.getByTestId(TestIds.linear.mobileWorkflows) @@ -100,6 +103,9 @@ export class AppModeHelper { await this.mobileWorkflows.click() await this.page.getByRole('menu').getByText(workflowName).click() } + async mobileNavigateTab(name: 'run' | 'outputs' | 'assets') { + await this.mobileNavigation.getByRole('tab', { name }).click() + } /** * Get the actions menu trigger for a widget in the app mode widget list. diff --git a/browser_tests/tests/appMode.spec.ts b/browser_tests/tests/appMode.spec.ts index 51d7f33a24..f3164de71c 100644 --- a/browser_tests/tests/appMode.spec.ts +++ b/browser_tests/tests/appMode.spec.ts @@ -36,23 +36,19 @@ test.describe('App mode usage', () => { }) test.describe('Mobile', { tag: ['@mobile'] }, () => { test('panel navigation', async ({ comfyPage }) => { - const { mobileView } = comfyPage.appMode + const { mobileNavigation, mobileView } = comfyPage.appMode await comfyPage.appMode.enterAppModeWithInputs([['3', 'steps']]) await expect(mobileView).toBeVisible() - const navigation = comfyPage.page - .getByRole('tablist') - .filter({ hasText: 'Assets' }) const panel = comfyPage.page.getByRole('tabpanel') - await expect(navigation).toBeVisible() - const buttons = await navigation.getByRole('tab').all() - await buttons[2].click() + await expect(mobileNavigation).toBeVisible() + await comfyPage.appMode.mobileNavigateTab('assets') await expect(panel).toContainClass('left-[200vw]') - //expect + const buttons = await mobileNavigation.getByRole('tab').all() await buttons[0].dragTo(buttons[2], { steps: 5 }) await expect(panel).toContainClass('left-[100vw]') - await navigation.getByRole('tab', { name: 'Edit & Run' }).click() + await comfyPage.appMode.mobileNavigateTab('run') const widgets = mobileView.getByTestId(TestIds.linear.widgetContainer) await expect(widgets).toBeInViewport({ ratio: 1 })