1.10.16 (#2771)

Co-authored-by: bymyself <cbyrne@comfy.org>
Co-authored-by: github-actions <github-actions@github.com>

browser_tests/helpers/templates.ts

@@ -1,4 +1,8 @@
 import { Locator, Page } from '@playwright/test'
+import path from 'path'
+
+import { CORE_TEMPLATES } from '../../src/constants/coreTemplates'
+import { TemplateInfo } from '../../src/types/workflowTemplateTypes'
 
 export class ComfyTemplates {
   readonly content: Locator
@@ -8,6 +12,17 @@ export class ComfyTemplates {
   }
 
   async loadTemplate(id: string) {
-    await this.content.getByTestId(`template-workflow-${id}`).click()
+    await this.content
+      .getByTestId(`template-workflow-${id}`)
+      .getByRole('img')
+      .click()
+  }
+
+  getAllTemplates(): TemplateInfo[] {
+    return CORE_TEMPLATES.flatMap((category) => category.templates)
+  }
+
+  getTemplatePath(filename: string): string {
+    return path.join('public', 'templates', filename)
   }
 }

browser_tests/templates.spec.ts

@@ -1,15 +1,58 @@
 import { expect } from '@playwright/test'
+import fs from 'fs'
 
 import { comfyPageFixture as test } from './fixtures/ComfyPage'
 
 test.describe('Templates', () => {
   test.beforeEach(async ({ comfyPage }) => {
     await comfyPage.setSetting('Comfy.UseNewMenu', 'Top')
+    await comfyPage.setSetting('Comfy.Workflow.ShowMissingModelsWarning', false)
+  })
+
+  test('should have a JSON workflow file for each template', async ({
+    comfyPage
+  }) => {
+    for (const template of comfyPage.templates.getAllTemplates()) {
+      const workflowPath = comfyPage.templates.getTemplatePath(
+        `${template.name}.json`
+      )
+      expect(
+        fs.existsSync(workflowPath),
+        `Missing workflow: ${template.name}`
+      ).toBe(true)
+    }
+  })
+
+  test('should have all required thumbnail media for each template', async ({
+    comfyPage
+  }) => {
+    for (const template of comfyPage.templates.getAllTemplates()) {
+      const { name, mediaSubtype, thumbnailVariant } = template
+      const baseMedia = `${name}-1.${mediaSubtype}`
+      const basePath = comfyPage.templates.getTemplatePath(baseMedia)
+
+      // Check base thumbnail
+      expect(
+        fs.existsSync(basePath),
+        `Missing base thumbnail: ${baseMedia}`
+      ).toBe(true)
+
+      // Check second thumbnail for variants that need it
+      if (
+        thumbnailVariant === 'compareSlider' ||
+        thumbnailVariant === 'hoverDissolve'
+      ) {
+        const secondMedia = `${name}-2.${mediaSubtype}`
+        const secondPath = comfyPage.templates.getTemplatePath(secondMedia)
+        expect(
+          fs.existsSync(secondPath),
+          `Missing second thumbnail: ${secondMedia} required for ${thumbnailVariant}`
+        ).toBe(true)
+      }
+    }
   })
 
   test('Can load template workflows', async ({ comfyPage }) => {
-    // This test will need expanding on once the templates are decided
-
     // Clear the workflow
     await comfyPage.menu.workflowsTab.open()
     await comfyPage.menu.workflowsTab.newBlankWorkflowButton.click()