mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-29 18:52:19 +00:00
Fix animated webp test and remove screenshot (#7632)
Remove screenshot expectation and restore test. We care that it's displaying an image not what frame of the image is being displayed. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7632-Fix-animated-webp-test-and-remove-screenshot-2ce6d73d365081a59d38dc9d82fa1a51) by [Unito](https://www.unito.io)
This commit is contained in:
@@ -262,13 +262,7 @@ test.describe('Animated image widget', () => {
|
|||||||
expect(filename).toContain('animated_webp.webp')
|
expect(filename).toContain('animated_webp.webp')
|
||||||
})
|
})
|
||||||
|
|
||||||
// FIXME: This test keeps flip-flopping because it relies on animated webp timing,
|
test('Can preview saved animated webp image', async ({ comfyPage }) => {
|
||||||
// which is inherently unreliable in CI environments. The test asset is an animated
|
|
||||||
// webp with 2 frames, and the test depends on animation frame timing to verify that
|
|
||||||
// animated webp images are properly displayed (as opposed to being treated as static webp).
|
|
||||||
// While the underlying functionality works (animated webp are correctly distinguished
|
|
||||||
// from static webp), the test is flaky due to timing dependencies with webp animation frames.
|
|
||||||
test.fixme('Can preview saved animated webp image', async ({ comfyPage }) => {
|
|
||||||
await comfyPage.loadWorkflow('widgets/save_animated_webp')
|
await comfyPage.loadWorkflow('widgets/save_animated_webp')
|
||||||
|
|
||||||
// Get position of the load animated webp node
|
// Get position of the load animated webp node
|
||||||
@@ -295,18 +289,13 @@ test.describe('Animated image widget', () => {
|
|||||||
([loadId, saveId]) => {
|
([loadId, saveId]) => {
|
||||||
// Set the output of the SaveAnimatedWEBP node to equal the loader node's image
|
// Set the output of the SaveAnimatedWEBP node to equal the loader node's image
|
||||||
window['app'].nodeOutputs[saveId] = window['app'].nodeOutputs[loadId]
|
window['app'].nodeOutputs[saveId] = window['app'].nodeOutputs[loadId]
|
||||||
|
app.canvas.setDirty(true)
|
||||||
},
|
},
|
||||||
[loadAnimatedWebpNode.id, saveAnimatedWebpNode.id]
|
[loadAnimatedWebpNode.id, saveAnimatedWebpNode.id]
|
||||||
)
|
)
|
||||||
await comfyPage.nextFrame()
|
await expect(
|
||||||
|
comfyPage.page.locator('.dom-widget').locator('img')
|
||||||
// Move mouse and click on canvas to trigger render
|
).toHaveCount(2)
|
||||||
await comfyPage.page.mouse.click(64, 64)
|
|
||||||
|
|
||||||
// Expect the SaveAnimatedWEBP node to have an output preview
|
|
||||||
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
||||||
'animated_image_preview_saved_webp.png'
|
|
||||||
)
|
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user