[Refactor] Replace explicit 'node' param with 'this' for TreeExplorer (#2427)

This commit is contained in:
Chenlei Hu
2025-02-05 12:20:08 -05:00
committed by GitHub
parent 2c12df12ab
commit 292af3fe3f
7 changed files with 48 additions and 74 deletions

View File

@@ -70,7 +70,7 @@ const renderedRoots = computed<RenderedTreeExplorerNode[]>(() => {
})
const getTreeNodeIcon = (node: TreeExplorerNode) => {
if (node.getIcon) {
const icon = node.getIcon(node)
const icon = node.getIcon()
if (icon) {
return icon
}
@@ -95,7 +95,7 @@ const fillNodeInfo = (node: TreeExplorerNode): RenderedTreeExplorerNode => {
children,
type: node.leaf ? 'node' : 'folder',
totalLeaves,
badgeText: node.getBadgeText ? node.getBadgeText(node) : null
badgeText: node.getBadgeText ? node.getBadgeText() : null
}
}
const onNodeContentClick = async (
@@ -106,7 +106,7 @@ const onNodeContentClick = async (
selectionKeys.value = {}
}
if (node.handleClick) {
await node.handleClick(node, e)
await node.handleClick(e)
}
emit('nodeClick', node, e)
}
@@ -128,7 +128,7 @@ const renameCommand = (node: RenderedTreeExplorerNode) => {
renameEditingNode.value = node
}
const deleteCommand = async (node: RenderedTreeExplorerNode) => {
await node.handleDelete?.(node)
await node.handleDelete?.()
emit('nodeDelete', node)
}
const menuItems = computed<MenuItem[]>(() =>

View File

@@ -83,7 +83,7 @@ const isEditing = computed(
const errorHandling = useErrorHandling()
const handleRename = errorHandling.wrapWithErrorHandlingAsync(
async (newName: string) => {
await props.node.handleRename(props.node, newName)
await props.node.handleRename(newName)
},
props.node.handleError,
() => {
@@ -110,7 +110,7 @@ if (props.node.draggable) {
? ({ nativeSetDragImage }) => {
setCustomNativeDragPreview({
render: ({ container }) => {
return props.node.renderDragPreview(props.node, container)
return props.node.renderDragPreview(container)
},
nativeSetDragImage
})
@@ -124,7 +124,7 @@ if (props.node.droppable) {
onDrop: async (event) => {
const dndData = event.source.data as TreeExplorerDragAndDropData
if (dndData.type === 'tree-explorer-node') {
await props.node.handleDrop?.(props.node, dndData)
await props.node.handleDrop?.(dndData)
canDrop.value = false
emit('itemDropped', props.node, dndData.data)
}