From 2d022e4e496de893a8a6c9a88285774697183f3f Mon Sep 17 00:00:00 2001
From: oto-ciulis-tt <62436273+oto-ciulis-tt@users.noreply.github.com>
Date: Wed, 27 Nov 2024 07:40:43 -0800
Subject: [PATCH] feat: Remove successful model downloads (#1710)

* feat: Remove successful model downloads

* PR comments

---------

Co-authored-by: Oto Ciulis <oto.ciulis@gmail.com>
---
 .../tabs/modelLibrary/ElectronDownloadItems.vue     |  6 +++---
 src/hooks/sidebarTabs/modelLibrarySidebarTab.ts     |  4 ++--
 src/stores/electronDownloadStore.ts                 | 13 +++++++++----
 3 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/src/components/sidebar/tabs/modelLibrary/ElectronDownloadItems.vue b/src/components/sidebar/tabs/modelLibrary/ElectronDownloadItems.vue
index 1106a5c37..ece5bd59c 100644
--- a/src/components/sidebar/tabs/modelLibrary/ElectronDownloadItems.vue
+++ b/src/components/sidebar/tabs/modelLibrary/ElectronDownloadItems.vue
@@ -1,10 +1,10 @@
 <template>
-  <div class="mx-6 mb-4" v-if="downloads.length > 0">
+  <div class="mx-6 mb-4" v-if="inProgressDownloads.length > 0">
     <div class="text-lg my-4">
       {{ $t('electronFileDownload.inProgress') }}
     </div>
 
-    <template v-for="download in downloads" :key="download.url">
+    <template v-for="download in inProgressDownloads" :key="download.url">
       <DownloadItem :download="download" />
     </template>
   </div>
@@ -16,5 +16,5 @@ import { useElectronDownloadStore } from '@/stores/electronDownloadStore'
 import { storeToRefs } from 'pinia'
 
 const electronDownloadStore = useElectronDownloadStore()
-const { downloads } = storeToRefs(electronDownloadStore)
+const { inProgressDownloads } = storeToRefs(electronDownloadStore)
 </script>
diff --git a/src/hooks/sidebarTabs/modelLibrarySidebarTab.ts b/src/hooks/sidebarTabs/modelLibrarySidebarTab.ts
index 7b0e20834..cfb1b93a6 100644
--- a/src/hooks/sidebarTabs/modelLibrarySidebarTab.ts
+++ b/src/hooks/sidebarTabs/modelLibrarySidebarTab.ts
@@ -18,8 +18,8 @@ export const useModelLibrarySidebarTab = (): SidebarTabExtension => {
     iconBadge: () => {
       if (isElectron()) {
         const electronDownloadStore = useElectronDownloadStore()
-        if (electronDownloadStore.downloads.length > 0) {
-          return electronDownloadStore.downloads.length.toString()
+        if (electronDownloadStore.inProgressDownloads.length > 0) {
+          return electronDownloadStore.inProgressDownloads.length.toString()
         }
       }
 
diff --git a/src/stores/electronDownloadStore.ts b/src/stores/electronDownloadStore.ts
index c5757a88b..91ad70682 100644
--- a/src/stores/electronDownloadStore.ts
+++ b/src/stores/electronDownloadStore.ts
@@ -1,8 +1,8 @@
-import { ref } from 'vue'
+import { computed, ref } from 'vue'
 import { defineStore } from 'pinia'
 import { isElectron, electronAPI } from '@/utils/envUtil'
-import type {
-  DownloadState,
+import {
+  type DownloadState,
   DownloadStatus
 } from '@comfyorg/comfyui-electron-types'
 
@@ -69,6 +69,11 @@ export const useElectronDownloadStore = defineStore('downloads', () => {
     resume,
     cancel,
     findByUrl,
-    initialize
+    initialize,
+    inProgressDownloads: computed(() =>
+      downloads.value.filter(
+        ({ status }) => status !== DownloadStatus.COMPLETED
+      )
+    )
   }
 })