From 302693bcd918c8e0067fa35ca375df6327d8a5bb Mon Sep 17 00:00:00 2001 From: DrJKL Date: Wed, 13 May 2026 12:14:31 -0700 Subject: [PATCH] test(subgraph): fix promoted widget store-key assertions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Drop the local `getHostStateName` helper that reconstructed the now-deleted encoded `[name, sourceNodeId, sourceWidgetName].join(':')` format. Use `widget.name` directly — the canonical store key after the entityId migration in c1515374b. Fixes 2 failing tests in SubgraphWidgetPromotion.test.ts. Amp-Thread-ID: https://ampcode.com/threads/T-019e2260-c2ba-70b4-9962-1638be4bf645 Co-authored-by: Amp --- .../subgraph/SubgraphWidgetPromotion.test.ts | 21 +++++-------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts b/src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts index a3aecffb8e..824206b94a 100644 --- a/src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts +++ b/src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts @@ -88,10 +88,6 @@ function expectPromotedWidgetView( }) } -function getHostStateName(widget: PromotedWidgetView): string { - return [widget.name, widget.sourceNodeId, widget.sourceWidgetName].join(':') -} - beforeEach(() => { setActivePinia(createTestingPinia({ stubActions: false })) resetSubgraphFixtureState() @@ -618,7 +614,7 @@ describe('SubgraphWidgetPromotion', () => { expectPromotedWidgetView(hostWidget) useWidgetValueStore().registerWidget(hostNode.rootGraph.id, { nodeId: hostNode.id, - name: getHostStateName(hostWidget), + name: hostWidget.name, type: hostWidget.type, value: 99, options: {} @@ -978,7 +974,7 @@ describe('SubgraphWidgetPromotion', () => { expect( useWidgetValueStore() .getNodeWidgets(host.rootGraph.id, host.id) - .find((entry) => entry.name.startsWith('seed:'))?.value + .find((entry) => entry.name === 'seed')?.value ).toBe(c.expect.storeSeedValue) } }) @@ -1080,18 +1076,11 @@ describe('SubgraphWidgetPromotion', () => { expectPromotedWidgetView(first) expectPromotedWidgetView(second) expect( - widgetStore.getWidget( - reloaded.rootGraph.id, - reloaded.id, - getHostStateName(first) - ) + widgetStore.getWidget(reloaded.rootGraph.id, reloaded.id, first.name) ).toBeUndefined() expect( - widgetStore.getWidget( - reloaded.rootGraph.id, - reloaded.id, - getHostStateName(second) - )?.value + widgetStore.getWidget(reloaded.rootGraph.id, reloaded.id, second.name) + ?.value ).toBe('second host value') expect( widgetStore.getNodeWidgets(reloaded.rootGraph.id, reloaded.id)