Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-03-01 19:20:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent reference sharing on settingStore content (#2160)

Browse Source
This commit is contained in:
Chenlei Hu
2025-01-04 19:31:32 -05:00
committed by GitHub
parent e65653c107
commit 31ea39e44c
2 changed files with 98 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/stores/settingStore.ts
View File

@@ -1,3 +1,4 @@
import _ from 'lodash'
import { defineStore } from 'pinia'
import type { TreeNode } from 'primevue/treenode'
import { computed, ref } from 'vue'
@@ -74,7 +75,12 @@ export const useSettingStore = defineStore('setting', () => {
* @param value - The value to set.
*/
async function set<K extends keyof Settings>(key: K, value: Settings[K]) {
const newValue = tryMigrateDeprecatedValue(settingsById.value[key], value)
// Clone the incoming value to prevent external mutations
const clonedValue = _.cloneDeep(value)
const newValue = tryMigrateDeprecatedValue(
settingsById.value[key],
clonedValue
)
const oldValue = get(key)
if (newValue === oldValue) return
@@ -89,7 +95,8 @@ export const useSettingStore = defineStore('setting', () => {
* @returns The value of the setting.
*/
function get<K extends keyof Settings>(key: K): Settings[K] {
return settingValues.value[key] ?? getDefaultValue(key)
// Clone the value when returning to prevent external mutations
return _.cloneDeep(settingValues.value[key] ?? getDefaultValue(key))
}
/**