mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-30 19:21:54 +00:00
fix: lint errors and test mock compatibility for Phase 2 integration
- Add void operator to fire-and-forget telemetry event hooks - Update @vueuse/core mocks to use importOriginal pattern Amp-Thread-ID: https://ampcode.com/threads/T-019c0082-e9c6-770f-ad30-cbc92ff266eb Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
@@ -11,11 +11,15 @@ vi.mock('@/platform/distribution/types', () => ({ isCloud: false }))
|
|||||||
vi.mock('@/platform/updates/common/releaseService')
|
vi.mock('@/platform/updates/common/releaseService')
|
||||||
vi.mock('@/platform/settings/settingStore')
|
vi.mock('@/platform/settings/settingStore')
|
||||||
vi.mock('@/stores/systemStatsStore')
|
vi.mock('@/stores/systemStatsStore')
|
||||||
vi.mock('@vueuse/core', () => ({
|
vi.mock('@vueuse/core', async (importOriginal) => {
|
||||||
until: vi.fn(() => Promise.resolve()),
|
const actual = await importOriginal()
|
||||||
useStorage: vi.fn(() => ({ value: {} })),
|
return {
|
||||||
createSharedComposable: vi.fn((fn) => fn)
|
...(actual as object),
|
||||||
}))
|
until: vi.fn(() => Promise.resolve()),
|
||||||
|
useStorage: vi.fn(() => ({ value: {} })),
|
||||||
|
createSharedComposable: vi.fn((fn) => fn)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
describe('useReleaseStore', () => {
|
describe('useReleaseStore', () => {
|
||||||
let store: ReturnType<typeof useReleaseStore>
|
let store: ReturnType<typeof useReleaseStore>
|
||||||
|
|||||||
@@ -323,12 +323,12 @@ export const useFirebaseAuthStore = defineStore('firebaseAuth', () => {
|
|||||||
)
|
)
|
||||||
|
|
||||||
if (isCloud) {
|
if (isCloud) {
|
||||||
authEventHook.trigger({
|
void authEventHook.trigger({
|
||||||
type: 'login',
|
type: 'login',
|
||||||
method: 'email',
|
method: 'email',
|
||||||
is_new_user: false
|
is_new_user: false
|
||||||
})
|
})
|
||||||
userResolvedHook.trigger({
|
void userResolvedHook.trigger({
|
||||||
userId: result.user.uid,
|
userId: result.user.uid,
|
||||||
email: result.user.email,
|
email: result.user.email,
|
||||||
displayName: result.user.displayName
|
displayName: result.user.displayName
|
||||||
@@ -349,12 +349,12 @@ export const useFirebaseAuthStore = defineStore('firebaseAuth', () => {
|
|||||||
)
|
)
|
||||||
|
|
||||||
if (isCloud) {
|
if (isCloud) {
|
||||||
authEventHook.trigger({
|
void authEventHook.trigger({
|
||||||
type: 'register',
|
type: 'register',
|
||||||
method: 'email',
|
method: 'email',
|
||||||
is_new_user: true
|
is_new_user: true
|
||||||
})
|
})
|
||||||
userResolvedHook.trigger({
|
void userResolvedHook.trigger({
|
||||||
userId: result.user.uid,
|
userId: result.user.uid,
|
||||||
email: result.user.email,
|
email: result.user.email,
|
||||||
displayName: result.user.displayName
|
displayName: result.user.displayName
|
||||||
@@ -373,12 +373,12 @@ export const useFirebaseAuthStore = defineStore('firebaseAuth', () => {
|
|||||||
if (isCloud) {
|
if (isCloud) {
|
||||||
const additionalUserInfo = getAdditionalUserInfo(result)
|
const additionalUserInfo = getAdditionalUserInfo(result)
|
||||||
const isNewUser = additionalUserInfo?.isNewUser ?? false
|
const isNewUser = additionalUserInfo?.isNewUser ?? false
|
||||||
authEventHook.trigger({
|
void authEventHook.trigger({
|
||||||
type: isNewUser ? 'register' : 'login',
|
type: isNewUser ? 'register' : 'login',
|
||||||
method: 'google',
|
method: 'google',
|
||||||
is_new_user: isNewUser
|
is_new_user: isNewUser
|
||||||
})
|
})
|
||||||
userResolvedHook.trigger({
|
void userResolvedHook.trigger({
|
||||||
userId: result.user.uid,
|
userId: result.user.uid,
|
||||||
email: result.user.email,
|
email: result.user.email,
|
||||||
displayName: result.user.displayName
|
displayName: result.user.displayName
|
||||||
@@ -397,12 +397,12 @@ export const useFirebaseAuthStore = defineStore('firebaseAuth', () => {
|
|||||||
if (isCloud) {
|
if (isCloud) {
|
||||||
const additionalUserInfo = getAdditionalUserInfo(result)
|
const additionalUserInfo = getAdditionalUserInfo(result)
|
||||||
const isNewUser = additionalUserInfo?.isNewUser ?? false
|
const isNewUser = additionalUserInfo?.isNewUser ?? false
|
||||||
authEventHook.trigger({
|
void authEventHook.trigger({
|
||||||
type: isNewUser ? 'register' : 'login',
|
type: isNewUser ? 'register' : 'login',
|
||||||
method: 'github',
|
method: 'github',
|
||||||
is_new_user: isNewUser
|
is_new_user: isNewUser
|
||||||
})
|
})
|
||||||
userResolvedHook.trigger({
|
void userResolvedHook.trigger({
|
||||||
userId: result.user.uid,
|
userId: result.user.uid,
|
||||||
email: result.user.email,
|
email: result.user.email,
|
||||||
displayName: result.user.displayName
|
displayName: result.user.displayName
|
||||||
|
|||||||
@@ -46,9 +46,11 @@ vi.mock('@/stores/workspace/colorPaletteStore', () => ({
|
|||||||
}))
|
}))
|
||||||
}))
|
}))
|
||||||
|
|
||||||
vi.mock('@vueuse/core', async () => {
|
vi.mock('@vueuse/core', async (importOriginal) => {
|
||||||
|
const actual = await importOriginal()
|
||||||
const { ref } = await import('vue')
|
const { ref } = await import('vue')
|
||||||
return {
|
return {
|
||||||
|
...(actual as object),
|
||||||
whenever: vi.fn(),
|
whenever: vi.fn(),
|
||||||
useStorage: vi.fn((_key, defaultValue) => {
|
useStorage: vi.fn((_key, defaultValue) => {
|
||||||
return ref(defaultValue)
|
return ref(defaultValue)
|
||||||
|
|||||||
Reference in New Issue
Block a user