diff --git a/browser_tests/assets/viewport/default-viewport-saved-offscreen.json b/browser_tests/assets/viewport/default-viewport-saved-offscreen.json index 69493e057a..9c785256a6 100644 --- a/browser_tests/assets/viewport/default-viewport-saved-offscreen.json +++ b/browser_tests/assets/viewport/default-viewport-saved-offscreen.json @@ -36,14 +36,7 @@ "properties": { "Node name for S&R": "CheckpointLoaderSimple", "cnr_id": "comfy-core", - "ver": "0.3.65", - "models": [ - { - "name": "v1-5-pruned-emaonly-fp16.safetensors", - "url": "https://huggingface.co/Comfy-Org/stable-diffusion-v1-5-archive/resolve/main/v1-5-pruned-emaonly-fp16.safetensors?download=true", - "directory": "checkpoints" - } - ] + "ver": "0.3.65" }, "widgets_values": ["v1-5-pruned-emaonly-fp16.safetensors"] }, diff --git a/browser_tests/fixtures/ComfyPage.ts b/browser_tests/fixtures/ComfyPage.ts index f0eaf29c6f..39393d2bbf 100644 --- a/browser_tests/fixtures/ComfyPage.ts +++ b/browser_tests/fixtures/ComfyPage.ts @@ -432,7 +432,10 @@ export const comfyPageFixture = base.extend<{ 'Comfy.VueNodes.AutoScaleLayout': false, // Disable toast warning about version compatibility, as they may or // may not appear - depending on upstream ComfyUI dependencies - 'Comfy.VersionCompatibility.DisableWarnings': true + 'Comfy.VersionCompatibility.DisableWarnings': true, + // Browser tests should opt into missing-model warnings explicitly so + // workflows do not render differently based on models present on disk. + 'Comfy.Workflow.ShowMissingModelsWarning': false }) } catch (e) { console.error(e) diff --git a/browser_tests/tests/dialog.spec.ts b/browser_tests/tests/dialog.spec.ts index bf2de274b7..93af2ea673 100644 --- a/browser_tests/tests/dialog.spec.ts +++ b/browser_tests/tests/dialog.spec.ts @@ -89,6 +89,17 @@ test.describe('Execution error', () => { }) test.describe('Missing models warning', () => { + test('Should be disabled by default in browser tests', async ({ + comfyPage + }) => { + await comfyPage.workflow.loadWorkflow('missing/missing_models') + + const dialogTitle = comfyPage.page.getByText( + 'This workflow is missing models' + ) + await expect(dialogTitle).not.toBeVisible() + }) + test.beforeEach(async ({ comfyPage }) => { await comfyPage.settings.setSetting( 'Comfy.Workflow.ShowMissingModelsWarning', diff --git a/browser_tests/tests/viewport.spec.ts-snapshots/viewport-fits-when-saved-offscreen-chromium-linux.png b/browser_tests/tests/viewport.spec.ts-snapshots/viewport-fits-when-saved-offscreen-chromium-linux.png index 4a5099db59..7215801e5e 100644 Binary files a/browser_tests/tests/viewport.spec.ts-snapshots/viewport-fits-when-saved-offscreen-chromium-linux.png and b/browser_tests/tests/viewport.spec.ts-snapshots/viewport-fits-when-saved-offscreen-chromium-linux.png differ