From 36e78860cf60e362d20d42c2ebaaf4f79ee57f8f Mon Sep 17 00:00:00 2001 From: Benjamin Lu Date: Mon, 11 May 2026 16:51:13 -0700 Subject: [PATCH] test: address asset scenario review feedback --- browser_tests/assets/example.jpg | Bin 0 -> 516 bytes .../fixtures/helpers/AssetScenarioHelper.ts | 15 +++++++++++++-- browser_tests/fixtures/helpers/mockAssetFiles.ts | 7 +++++++ 3 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 browser_tests/assets/example.jpg diff --git a/browser_tests/assets/example.jpg b/browser_tests/assets/example.jpg new file mode 100644 index 0000000000000000000000000000000000000000..a98482cd0ab835fb993473b2bf015926c2970117 GIT binary patch literal 516 zcmbu4JqkiG5QJwEo}{qYfYzcOB!%!mFJbA?yoQB`@Tc)6`!)teF{XKwE_}>>qZfTZ zcKx;o3D6$&jtz8dtb}7b^n@6)l;;XA(nsnU^QS64)7ke-%>6rh!_*T_yx6wCOt9(f z+%W^ORuW8riR%X7-au6&pO_?fXgj3k{-q3WQ>1!Oj44L4XaL!$06#{h!A57`Isgg< Bw?Y5_ literal 0 HcmV?d00001 diff --git a/browser_tests/fixtures/helpers/AssetScenarioHelper.ts b/browser_tests/fixtures/helpers/AssetScenarioHelper.ts index 2d7555b419..58cdad923f 100644 --- a/browser_tests/fixtures/helpers/AssetScenarioHelper.ts +++ b/browser_tests/fixtures/helpers/AssetScenarioHelper.ts @@ -22,6 +22,9 @@ const inputFilesRoutePattern = /\/internal\/files\/input(?:\?.*)?$/ const viewRoutePattern = /\/api\/view(?:\?.*)?$/ const DEFAULT_FIXTURE_CREATE_TIME = Date.UTC(2024, 0, 1, 0, 0, 0) +type InputFilesResponse = string[] +type ViewErrorResponse = { error: string } + type MockPreviewOutput = NonNullable & { filename?: string subfolder?: string @@ -214,10 +217,14 @@ export class AssetScenarioHelper { } this.inputFilesRouteHandler = async (route: Route) => { + const response = this.importedFiles.map( + (asset) => asset.name + ) satisfies InputFilesResponse + await route.fulfill({ status: 200, contentType: 'application/json', - body: JSON.stringify(this.importedFiles.map((asset) => asset.name)) + body: JSON.stringify(response) }) } @@ -236,10 +243,14 @@ export class AssetScenarioHelper { const subfolder = url.searchParams.get('subfolder') ?? '' if (!filename) { + const response = { + error: 'Missing filename' + } satisfies ViewErrorResponse + await route.fulfill({ status: 400, contentType: 'application/json', - body: JSON.stringify({ error: 'Missing filename' }) + body: JSON.stringify(response) }) return } diff --git a/browser_tests/fixtures/helpers/mockAssetFiles.ts b/browser_tests/fixtures/helpers/mockAssetFiles.ts index d692ff6731..f0e2cb1e0b 100644 --- a/browser_tests/fixtures/helpers/mockAssetFiles.ts +++ b/browser_tests/fixtures/helpers/mockAssetFiles.ts @@ -55,6 +55,13 @@ export function defaultFileFor(filename: string): MockAssetFile { } } + if (normalized.endsWith('.jpg') || normalized.endsWith('.jpeg')) { + return { + filePath: getFixturePath('example.jpg'), + contentType: 'image/jpeg' + } + } + if (normalized.endsWith('.webm')) { return { filePath: getFixturePath('workflowInMedia/workflow.webm'),