From 38695ae0b562777b3428c20e92b3992dc0cc7127 Mon Sep 17 00:00:00 2001 From: snomiao Date: Mon, 20 Oct 2025 13:44:22 +0000 Subject: [PATCH] [ci] Remove all actions/cache steps from workflows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit removes the entire actions/cache steps (not just .cache directory) from all workflow files to measure the true performance impact of caching vs no caching. Changes: - ci-lint-format.yaml: Removed tool outputs cache - ci-tests-storybook.yaml: Removed storybook build cache (both jobs) - ci-tests-unit.yaml: Removed coverage and vitest cache - api-update-electron-api-types.yaml: Removed tsbuildinfo cache - api-update-manager-api-types.yaml: Removed tool cache and repo cache - api-update-registry-api-types.yaml: Removed tool cache and repo cache - release-draft-create.yaml: Removed tsbuildinfo cache - release-pypi-dev.yaml: Removed dist and tsbuildinfo cache Note: pnpm package caching via setup-node still remains active. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- .../api-update-electron-api-types.yaml | 9 ------- .../api-update-manager-api-types.yaml | 17 ------------- .../api-update-registry-api-types.yaml | 17 ------------- .github/workflows/ci-lint-format.yaml | 14 ----------- .github/workflows/ci-tests-storybook.yaml | 24 ------------------- .github/workflows/ci-tests-unit.yaml | 12 ---------- .github/workflows/release-draft-create.yaml | 9 ------- .github/workflows/release-pypi-dev.yaml | 10 -------- 8 files changed, 112 deletions(-) diff --git a/.github/workflows/api-update-electron-api-types.yaml b/.github/workflows/api-update-electron-api-types.yaml index 3465ba908..c25742118 100644 --- a/.github/workflows/api-update-electron-api-types.yaml +++ b/.github/workflows/api-update-electron-api-types.yaml @@ -26,15 +26,6 @@ jobs: node-version: lts/* cache: 'pnpm' - - name: Cache tool outputs - uses: actions/cache@v4 - with: - path: | - tsconfig.tsbuildinfo - key: electron-types-tools-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }} - restore-keys: | - electron-types-tools-cache-${{ runner.os }}- - - name: Update electron types run: pnpm install --workspace-root @comfyorg/comfyui-electron-types@latest diff --git a/.github/workflows/api-update-manager-api-types.yaml b/.github/workflows/api-update-manager-api-types.yaml index 6a2242d88..4961ae9d2 100644 --- a/.github/workflows/api-update-manager-api-types.yaml +++ b/.github/workflows/api-update-manager-api-types.yaml @@ -31,26 +31,9 @@ jobs: node-version: lts/* cache: 'pnpm' - - name: Cache tool outputs - uses: actions/cache@v4 - with: - path: | - tsconfig.tsbuildinfo - key: update-manager-tools-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }} - restore-keys: | - update-manager-tools-cache-${{ runner.os }}- - - name: Install dependencies run: pnpm install --frozen-lockfile - - name: Cache ComfyUI-Manager repository - uses: actions/cache@v4 - with: - path: ComfyUI-Manager - key: comfyui-manager-repo-${{ runner.os }}-${{ github.run_id }} - restore-keys: | - comfyui-manager-repo-${{ runner.os }}- - - name: Checkout ComfyUI-Manager repository uses: actions/checkout@v5 with: diff --git a/.github/workflows/api-update-registry-api-types.yaml b/.github/workflows/api-update-registry-api-types.yaml index 7303acd2d..41a3d0a7a 100644 --- a/.github/workflows/api-update-registry-api-types.yaml +++ b/.github/workflows/api-update-registry-api-types.yaml @@ -30,26 +30,9 @@ jobs: node-version: lts/* cache: 'pnpm' - - name: Cache tool outputs - uses: actions/cache@v4 - with: - path: | - tsconfig.tsbuildinfo - key: update-registry-tools-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }} - restore-keys: | - update-registry-tools-cache-${{ runner.os }}- - - name: Install dependencies run: pnpm install --frozen-lockfile - - name: Cache comfy-api repository - uses: actions/cache@v4 - with: - path: comfy-api - key: comfy-api-repo-${{ runner.os }}-${{ github.run_id }} - restore-keys: | - comfy-api-repo-${{ runner.os }}- - - name: Checkout comfy-api repository uses: actions/checkout@v5 with: diff --git a/.github/workflows/ci-lint-format.yaml b/.github/workflows/ci-lint-format.yaml index 571cbaea8..71d5eed15 100644 --- a/.github/workflows/ci-lint-format.yaml +++ b/.github/workflows/ci-lint-format.yaml @@ -33,20 +33,6 @@ jobs: node-version: 'lts/*' cache: 'pnpm' - - name: Cache tool outputs - uses: actions/cache@v4 - with: - path: | - .eslintcache - tsconfig.tsbuildinfo - .prettierCache - .knip-cache - key: lint-format-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ hashFiles('src/**/*.{ts,vue,js,mts}', '*.config.*', '.eslintrc.*', '.prettierrc.*', 'tsconfig.json') }} - restore-keys: | - lint-format-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}- - lint-format-cache-${{ runner.os }}- - ci-tools-cache-${{ runner.os }}- - - name: Install dependencies run: pnpm install --frozen-lockfile diff --git a/.github/workflows/ci-tests-storybook.yaml b/.github/workflows/ci-tests-storybook.yaml index 6c171bc04..77dcf5210 100644 --- a/.github/workflows/ci-tests-storybook.yaml +++ b/.github/workflows/ci-tests-storybook.yaml @@ -50,18 +50,6 @@ jobs: node-version: '20' cache: 'pnpm' - - name: Cache tool outputs - uses: actions/cache@v4 - with: - path: | - storybook-static - tsconfig.tsbuildinfo - key: storybook-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ hashFiles('src/**/*.{ts,vue,js}', '*.config.*', '.storybook/**/*') }} - restore-keys: | - storybook-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}- - storybook-cache-${{ runner.os }}- - storybook-tools-cache-${{ runner.os }}- - - name: Install dependencies run: pnpm install --frozen-lockfile @@ -114,18 +102,6 @@ jobs: node-version: '20' cache: 'pnpm' - - name: Cache tool outputs - uses: actions/cache@v4 - with: - path: | - storybook-static - tsconfig.tsbuildinfo - key: storybook-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ hashFiles('src/**/*.{ts,vue,js}', '*.config.*', '.storybook/**/*') }} - restore-keys: | - storybook-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}- - storybook-cache-${{ runner.os }}- - storybook-tools-cache-${{ runner.os }}- - - name: Install dependencies run: pnpm install --frozen-lockfile diff --git a/.github/workflows/ci-tests-unit.yaml b/.github/workflows/ci-tests-unit.yaml index a975431f4..2f4417594 100644 --- a/.github/workflows/ci-tests-unit.yaml +++ b/.github/workflows/ci-tests-unit.yaml @@ -29,18 +29,6 @@ jobs: node-version: "lts/*" cache: "pnpm" - - name: Cache tool outputs - uses: actions/cache@v4 - with: - path: | - coverage - .vitest-cache - key: vitest-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ hashFiles('src/**/*.{ts,vue,js}', 'vitest.config.*', 'tsconfig.json') }} - restore-keys: | - vitest-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}- - vitest-cache-${{ runner.os }}- - test-tools-cache-${{ runner.os }}- - - name: Install dependencies run: pnpm install --frozen-lockfile diff --git a/.github/workflows/release-draft-create.yaml b/.github/workflows/release-draft-create.yaml index 263825294..749523104 100644 --- a/.github/workflows/release-draft-create.yaml +++ b/.github/workflows/release-draft-create.yaml @@ -28,15 +28,6 @@ jobs: node-version: 'lts/*' cache: 'pnpm' - - name: Cache tool outputs - uses: actions/cache@v4 - with: - path: | - tsconfig.tsbuildinfo - key: release-tools-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }} - restore-keys: | - release-tools-cache-${{ runner.os }}- - - name: Get current version id: current_version run: echo "version=$(node -p "require('./package.json').version")" >> $GITHUB_OUTPUT diff --git a/.github/workflows/release-pypi-dev.yaml b/.github/workflows/release-pypi-dev.yaml index 30e8638a7..868321759 100644 --- a/.github/workflows/release-pypi-dev.yaml +++ b/.github/workflows/release-pypi-dev.yaml @@ -25,16 +25,6 @@ jobs: node-version: 'lts/*' cache: 'pnpm' - - name: Cache tool outputs - uses: actions/cache@v4 - with: - path: | - dist - tsconfig.tsbuildinfo - key: dev-release-tools-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }} - restore-keys: | - dev-release-tools-cache-${{ runner.os }}- - - name: Get current version id: current_version run: echo "version=$(node -p "require('./package.json').version")" >> $GITHUB_OUTPUT