From 39bab9d9e24af7639d07ae1a7a0dd52084585256 Mon Sep 17 00:00:00 2001 From: Chenlei Hu Date: Fri, 15 Nov 2024 20:55:18 -0500 Subject: [PATCH] Disable flaky group node test (#1560) --- browser_tests/groupNode.spec.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/browser_tests/groupNode.spec.ts b/browser_tests/groupNode.spec.ts index 92c8e6c05..bb3505ee6 100644 --- a/browser_tests/groupNode.spec.ts +++ b/browser_tests/groupNode.spec.ts @@ -77,8 +77,13 @@ test.describe('Group Node', () => { .click() }) }) - - test('Can be added to canvas using search', async ({ comfyPage }) => { + // The 500ms fixed delay on the search results is causing flakiness + // Potential solution: add a spinner state when the search is in progress, + // and observe that state from the test. Blocker: the PrimeVue AutoComplete + // does not have a v-model on the query, so we cannot observe the raw + // query update, and thus cannot set the spinning state between the raw query + // update and the debounced search update. + test.skip('Can be added to canvas using search', async ({ comfyPage }) => { const groupNodeName = 'DefautWorkflowGroupNode' await comfyPage.convertAllNodesToGroupNode(groupNodeName) await comfyPage.doubleClickCanvas()