mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-05 21:54:50 +00:00
ci: filter e2e workflow on PRs to skip unrelated changes (#11568)
## Summary Skip the main e2e test suite on PRs that only touch unrelated paths (website, docs, storybook, markdown). ## Changes - **What**: Replace the broad `paths-ignore: ['**/*.md']` on the `pull_request` trigger with a more targeted `paths-ignore` list covering `apps/**`, `docs/**`, `**/*.md`, and `.storybook/**`. The `push` (to main), `merge_group`, and `workflow_dispatch` triggers remain unconditional. ## Review Focus - The `merge_group` trigger has no path filter, so the merge queue always runs e2e as a safety net before merge. - Using `paths-ignore` (denylist) rather than `paths` (allowlist) so new top-level directories trigger e2e by default. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11568-ci-filter-e2e-workflow-on-PRs-to-skip-unrelated-changes-34b6d73d365081ea8603ef94bc86b6e6) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
11
.github/workflows/ci-tests-e2e-forks.yaml
vendored
11
.github/workflows/ci-tests-e2e-forks.yaml
vendored
@@ -51,15 +51,16 @@ jobs:
|
||||
|
||||
- name: Download and Deploy Reports
|
||||
if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed'
|
||||
uses: actions/download-artifact@v7
|
||||
uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
|
||||
with:
|
||||
github-token: ${{ secrets.GITHUB_TOKEN }}
|
||||
run-id: ${{ github.event.workflow_run.id }}
|
||||
pattern: playwright-report-*
|
||||
run_id: ${{ github.event.workflow_run.id }}
|
||||
name: playwright-report-.*
|
||||
name_is_regexp: true
|
||||
path: reports
|
||||
if_no_artifact_found: warn
|
||||
|
||||
- name: Handle Test Completion
|
||||
if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed'
|
||||
if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed' && hashFiles('reports/**') != ''
|
||||
env:
|
||||
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
|
||||
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
|
||||
|
||||
Reference in New Issue
Block a user