Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-30 19:21:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Upgrade Vitest to v4 (#7797)

Browse Source 
## Summary

https://vitest.dev/guide/migration.html#vitest-4

## Changes

- **What**: Update Vitest and some associated dependencies
- **What**: Fix issue with our existing mocks and mock types

## Review Focus

Double check the test updates. I tried to keep the changes minimal.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7797-Chore-Upgrade-Vitest-to-v4-2d96d73d3650810cbe3ac42d7bd6585a)
by [Unito](https://www.unito.io)

---------

Co-authored-by: GitHub Action <action@github.com>
This commit is contained in:
Alexander Brown
2025-12-29 19:24:35 -08:00
committed by GitHub
parent 91ed58acc9
commit 3ae2b52649
22 changed files with 615 additions and 576 deletions
Download Patch File Download Diff File Expand all files Collapse all files

87
tests-ui/tests/lib/litegraph/src/widgets/ComboWidget.test.ts
View File

@@ -10,14 +10,6 @@ const { LGraphCanvas } = await vi.importActual<
>('@/lib/litegraph/src/LGraphCanvas')
type LGraphCanvasType = InstanceType<typeof LGraphCanvas>
type ContextMenuInstance = {
addItem?: (
name: string,
value: string,
options: { callback?: (value: string) => void; className?: string }
) => void
}
interface MockWidgetConfig extends Omit<IComboWidget, 'options'> {
options: IComboWidget['options']
}
@@ -465,12 +457,12 @@ describe('ComboWidget', () => {
node.size = [200, 30]
let capturedCallback: ((value: string) => void) | undefined
const mockContextMenu = vi.fn((_values, options) => {
capturedCallback = options.callback
return {} as ContextMenuInstance
})
LiteGraph.ContextMenu =
mockContextMenu as unknown as typeof LiteGraph.ContextMenu
const mockContextMenu = vi
.fn<typeof LiteGraph.ContextMenu>()
.mockImplementation(function (_values, options) {
capturedCallback = options.callback
})
LiteGraph.ContextMenu = mockContextMenu
const setValueSpy = vi.spyOn(widget, 'setValue')
widget.onClick({ e: mockEvent, node, canvas: mockCanvas })
@@ -507,12 +499,12 @@ describe('ComboWidget', () => {
node.size = [200, 30]
let capturedCallback: ((value: string) => void) | undefined
const mockContextMenu = vi.fn((_values, options) => {
capturedCallback = options.callback
return {} as ContextMenuInstance
})
LiteGraph.ContextMenu =
mockContextMenu as unknown as typeof LiteGraph.ContextMenu
const mockContextMenu = vi
.fn<typeof LiteGraph.ContextMenu>()
.mockImplementation(function (_values, options) {
capturedCallback = options.callback
})
LiteGraph.ContextMenu = mockContextMenu
const setValueSpy = vi.spyOn(widget, 'setValue')
widget.onClick({ e: mockEvent, node, canvas: mockCanvas })
@@ -653,7 +645,7 @@ describe('ComboWidget', () => {
})
it('should handle getOptionLabel error gracefully', () => {
const mockGetOptionLabel = vi.fn().mockImplementation(() => {
const mockGetOptionLabel = vi.fn().mockImplementation(function () {
throw new Error('Formatting failed')
})
const consoleErrorSpy = vi
@@ -768,9 +760,12 @@ describe('ComboWidget', () => {
node.size = [200, 30]
const mockAddItem = vi.fn()
const mockContextMenu = vi.fn(() => ({ addItem: mockAddItem }))
LiteGraph.ContextMenu =
mockContextMenu as unknown as typeof LiteGraph.ContextMenu
const mockContextMenu = vi
.fn<typeof LiteGraph.ContextMenu>()
.mockImplementation(function () {
this.addItem = mockAddItem
})
LiteGraph.ContextMenu = mockContextMenu
widget.onClick({ e: mockEvent, node, canvas: mockCanvas })
@@ -827,12 +822,13 @@ describe('ComboWidget', () => {
const mockAddItem = vi.fn()
let capturedCallback: ((value: string) => void) | undefined
const mockContextMenu = vi.fn((_values, options) => {
capturedCallback = options.callback
return { addItem: mockAddItem }
})
LiteGraph.ContextMenu =
mockContextMenu as unknown as typeof LiteGraph.ContextMenu
const mockContextMenu = vi
.fn<typeof LiteGraph.ContextMenu>()
.mockImplementation(function (_values, options) {
capturedCallback = options.callback
this.addItem = mockAddItem
})
LiteGraph.ContextMenu = mockContextMenu
const setValueSpy = vi.spyOn(widget, 'setValue')
widget.onClick({ e: mockEvent, node, canvas: mockCanvas })
@@ -879,12 +875,13 @@ describe('ComboWidget', () => {
const mockAddItem = vi.fn()
let capturedCallback: ((value: string) => void) | undefined
const mockContextMenu = vi.fn((_values, options) => {
capturedCallback = options.callback
return { addItem: mockAddItem } as ContextMenuInstance
})
LiteGraph.ContextMenu =
mockContextMenu as unknown as typeof LiteGraph.ContextMenu
const mockContextMenu = vi
.fn<typeof LiteGraph.ContextMenu>()
.mockImplementation(function (_values, options) {
capturedCallback = options.callback
this.addItem = mockAddItem
})
LiteGraph.ContextMenu = mockContextMenu
widget.onClick({ e: mockEvent, node, canvas: mockCanvas })
@@ -931,7 +928,7 @@ describe('ComboWidget', () => {
const mockGetOptionLabel = vi
.fn()
.mockReturnValueOnce('Beautiful Sunset.png')
.mockImplementationOnce(() => {
.mockImplementationOnce(function () {
throw new Error('Formatting failed')
})
@@ -957,11 +954,12 @@ describe('ComboWidget', () => {
.mockImplementation(() => {})
const mockAddItem = vi.fn()
const mockContextMenu = vi.fn(() => {
return { addItem: mockAddItem } as ContextMenuInstance
})
LiteGraph.ContextMenu =
mockContextMenu as unknown as typeof LiteGraph.ContextMenu
const mockContextMenu = vi
.fn<typeof LiteGraph.ContextMenu>()
.mockImplementation(function () {
this.addItem = mockAddItem
})
LiteGraph.ContextMenu = mockContextMenu
widget.onClick({ e: mockEvent, node, canvas: mockCanvas })
@@ -1007,9 +1005,8 @@ describe('ComboWidget', () => {
node.pos = [50, 50]
node.size = [200, 30]
const mockContextMenu = vi.fn()
LiteGraph.ContextMenu =
mockContextMenu as unknown as typeof LiteGraph.ContextMenu
const mockContextMenu = vi.fn<typeof LiteGraph.ContextMenu>()
LiteGraph.ContextMenu = mockContextMenu
widget.onClick({ e: mockEvent, node, canvas: mockCanvas })