mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-28 10:12:11 +00:00
fix: update imagePreview browser tests to use current fixture APIs (#8995)
The browser tests added in #8143 were failing on main because they were written against stale `ComfyPage` APIs that were refactored in #8510 (merged Feb 3, before #8143 merged Feb 18). ### Changes - `comfyPage.dragAndDropFile` → `comfyPage.dragDrop.dragAndDropFile` - `comfyPage.setSetting` → `comfyPage.settings.setSetting` - `comfyPage.loadWorkflow` → `comfyPage.workflow.loadWorkflow` - `comfyPage.getNodeRefsByType` → `comfyPage.nodeOps.getNodeRefsByType` - Fix `comfyPage` type parameter to use `ComfyPage` import - Remove `test.fixme` since root cause was API mismatch, not test logic ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8995-fix-update-imagePreview-browser-tests-to-use-current-fixture-APIs-30d6d73d365081219c1eda4ea7251160) by [Unito](https://www.unito.io)
This commit is contained in:
@@ -1,23 +1,22 @@
|
|||||||
import { expect } from '@playwright/test'
|
import { expect } from '@playwright/test'
|
||||||
|
|
||||||
|
import type { ComfyPage } from '../../../../fixtures/ComfyPage'
|
||||||
import { comfyPageFixture as test } from '../../../../fixtures/ComfyPage'
|
import { comfyPageFixture as test } from '../../../../fixtures/ComfyPage'
|
||||||
|
|
||||||
test.describe('Vue Nodes Image Preview', () => {
|
test.describe('Vue Nodes Image Preview', () => {
|
||||||
test.beforeEach(async ({ comfyPage }) => {
|
test.beforeEach(async ({ comfyPage }) => {
|
||||||
await comfyPage.setSetting('Comfy.VueNodes.Enabled', true)
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
||||||
await comfyPage.loadWorkflow('widgets/load_image_widget')
|
await comfyPage.workflow.loadWorkflow('widgets/load_image_widget')
|
||||||
await comfyPage.vueNodes.waitForNodes()
|
await comfyPage.vueNodes.waitForNodes()
|
||||||
})
|
})
|
||||||
|
|
||||||
async function loadImageOnNode(
|
async function loadImageOnNode(comfyPage: ComfyPage) {
|
||||||
comfyPage: Awaited<
|
const loadImageNode = (
|
||||||
ReturnType<(typeof test)['info']>
|
await comfyPage.nodeOps.getNodeRefsByType('LoadImage')
|
||||||
>['fixtures']['comfyPage']
|
)[0]
|
||||||
) {
|
|
||||||
const loadImageNode = (await comfyPage.getNodeRefsByType('LoadImage'))[0]
|
|
||||||
const { x, y } = await loadImageNode.getPosition()
|
const { x, y } = await loadImageNode.getPosition()
|
||||||
|
|
||||||
await comfyPage.dragAndDropFile('image64x64.webp', {
|
await comfyPage.dragDrop.dragAndDropFile('image64x64.webp', {
|
||||||
dropPosition: { x, y }
|
dropPosition: { x, y }
|
||||||
})
|
})
|
||||||
|
|
||||||
@@ -29,6 +28,7 @@ test.describe('Vue Nodes Image Preview', () => {
|
|||||||
return imagePreview
|
return imagePreview
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// TODO(#8143): Re-enable after image preview sync is working in CI
|
||||||
test.fixme('opens mask editor from image preview button', async ({
|
test.fixme('opens mask editor from image preview button', async ({
|
||||||
comfyPage
|
comfyPage
|
||||||
}) => {
|
}) => {
|
||||||
@@ -40,6 +40,7 @@ test.describe('Vue Nodes Image Preview', () => {
|
|||||||
await expect(comfyPage.page.locator('.mask-editor-dialog')).toBeVisible()
|
await expect(comfyPage.page.locator('.mask-editor-dialog')).toBeVisible()
|
||||||
})
|
})
|
||||||
|
|
||||||
|
// TODO(#8143): Re-enable after image preview sync is working in CI
|
||||||
test.fixme('shows image context menu options', async ({ comfyPage }) => {
|
test.fixme('shows image context menu options', async ({ comfyPage }) => {
|
||||||
await loadImageOnNode(comfyPage)
|
await loadImageOnNode(comfyPage)
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user