From 3eedff3876b251377822f2c3fb0f881808d50d50 Mon Sep 17 00:00:00 2001
From: AustinMroz <austin@comfy.org>
Date: Mon, 6 Oct 2025 13:09:54 -0700
Subject: [PATCH] Fix untyped subgraph node outputs in vue mode (#5930)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Under some infrequent circumstances, the node outputs of subgraphNodes
lack the boundingRect property. As this is a required property of
`INodeSlot`s, it's presence is required to satisfy isSlotObject and the
type information is discarded to instead display a placeholder output.

This boundingRect property is not used by vue nodes and the type of
nodeData.outputs already satisfies INodeSlot, so this entire typeguard
and computed can be removed.

<img width="405" height="209" alt="image"
src="https://github.com/user-attachments/assets/8563abb7-b619-495e-b9ec-e3274e7668cf"
/>


┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5930-Fix-untyped-subgraph-node-outputs-in-vue-mode-2836d73d3650814f993fc71590eca79b)
by [Unito](https://www.unito.io)
---
 .../vueNodes/components/NodeSlots.vue          | 18 ++----------------
 1 file changed, 2 insertions(+), 16 deletions(-)

diff --git a/src/renderer/extensions/vueNodes/components/NodeSlots.vue b/src/renderer/extensions/vueNodes/components/NodeSlots.vue
index e4617a4c9..df2adc60e 100644
--- a/src/renderer/extensions/vueNodes/components/NodeSlots.vue
+++ b/src/renderer/extensions/vueNodes/components/NodeSlots.vue
@@ -14,9 +14,9 @@
       />
     </div>
 
-    <div v-if="filteredOutputs.length" class="flex flex-col gap-1 ml-auto">
+    <div v-if="nodeData?.outputs?.length" class="flex flex-col gap-1 ml-auto">
       <OutputSlot
-        v-for="(output, index) in filteredOutputs"
+        v-for="(output, index) in nodeData.outputs"
         :key="`output-${index}`"
         :slot-data="output"
         :node-type="nodeData?.type || ''"
@@ -68,20 +68,6 @@ const filteredInputs = computed(() => {
     )
 })
 
-// Outputs don't have widgets, so we don't need to filter them
-const filteredOutputs = computed(() => {
-  const outputs = nodeData?.outputs || []
-  return outputs.map((output) =>
-    isSlotObject(output)
-      ? output
-      : ({
-          name: typeof output === 'string' ? output : '',
-          type: 'any',
-          boundingRect: [0, 0, 0, 0] as [number, number, number, number]
-        } as INodeSlot)
-  )
-})
-
 // Get the actual index of an input slot in the node's inputs array
 // (accounting for filtered widget slots)
 const getActualInputIndex = (