Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-05-03 04:31:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Squash: decouple link/reroute rendering changes

Browse Source 
Range: c3b7053f..709570b8

Commits: - a2648349 fix(Reroute): remove unsafe this alias in computeRenderParams; capture id and use it inside helper
 - 89d6ae1a Lazy compute
 - e78326ac refactor(litegraph): decouple link dragging render state from model
 - 6d3a035a refactor(litegraph): remove reroute._dragging; track reroute hiding ephemerally
 - d0870533 refactor(litegraph): decouple reroute render geometry and respect hidden reroutes
 - 709570b8 refactor(litegraph): decouple reroute rendering state from models and canvas
(cherry picked from commit 23f0a7403117a71e99095446443a8f5acec8f582)
This commit is contained in:
Benjamin Lu
2025-08-11 22:16:17 -04:00
parent d068b8351e
commit 40b92670a6
17 changed files with 682 additions and 465 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/lib/litegraph/test/LinkConnector.test.ts
View File

@@ -124,7 +124,7 @@ describe('LinkConnector', () => {
expect(connector.state.connectingTo).toBe('input')
expect(connector.state.draggingExistingLinks).toBe(true)
expect(connector.inputLinks).toContain(link)
expect(link._dragging).toBe(true)
expect(connector.isLinkBeingDragged(link.id)).toBe(true)
})
test('should not move input link if already connecting', ({
@@ -162,7 +162,7 @@ describe('LinkConnector', () => {
expect(connector.state.draggingExistingLinks).toBe(true)
expect(connector.state.multi).toBe(true)
expect(connector.outputLinks).toContain(link)
expect(link._dragging).toBe(true)
expect(connector.isLinkBeingDragged(link.id)).toBe(true)
})
test('should not move output link if already connecting', ({
@@ -253,12 +253,11 @@ describe('LinkConnector', () => {
connector.state.draggingExistingLinks = true
const link = new LLink(1, 'number', 1, 0, 2, 0)
link._dragging = true
connector.inputLinks.push(link)
connector.draggingLinkIds.add(link.id)
const reroute = new Reroute(1, network)
reroute.pos = [0, 0]
reroute._dragging = true
connector.hiddenReroutes.add(reroute)
connector.reset()
@@ -272,8 +271,7 @@ describe('LinkConnector', () => {
expect(connector.inputLinks).toEqual([])
expect(connector.outputLinks).toEqual([])
expect(connector.hiddenReroutes.size).toBe(0)
expect(link._dragging).toBeUndefined()
expect(reroute._dragging).toBeUndefined()
expect(connector.draggingLinkIds.size).toBe(0)
})
})