From 414935594c958241007744d1f617e4eeae6ea797 Mon Sep 17 00:00:00 2001 From: snomiao Date: Sat, 13 Sep 2025 14:41:40 +0000 Subject: [PATCH] chore: update import statements to use 'type' for type-only imports for better clarity and performance refactor(collect-i18n-node-defs): clean up comments for clarity on API endpoint behavior --- scripts/collect-i18n-node-defs.ts | 10 +--------- src/composables/nodePack/useMissingNodes.ts | 4 ++-- src/composables/nodePack/useWorkflowPacks.ts | 2 +- tests-ui/tests/composables/useNodeChatHistory.test.ts | 2 +- 4 files changed, 5 insertions(+), 13 deletions(-) diff --git a/scripts/collect-i18n-node-defs.ts b/scripts/collect-i18n-node-defs.ts index 3ac53b05c6..d1bae29dc0 100644 --- a/scripts/collect-i18n-node-defs.ts +++ b/scripts/collect-i18n-node-defs.ts @@ -19,15 +19,7 @@ test('collect-i18n-node-defs', async ({ comfyPage }) => { }) }) - // Don't mock the object_info API endpoint - let it hit the actual backend - // Comment out the mock to use real backend data - // await comfyPage.page.route('**/api/object_info', async (route) => { - // await route.fulfill({ - // status: 200, - // contentType: 'application/json', - // body: JSON.stringify({}) - // }) - // }) + // Note: Don't mock the object_info API endpoint - let it hit the actual backend const nodeDefs: ComfyNodeDefImpl[] = ( Object.values( diff --git a/src/composables/nodePack/useMissingNodes.ts b/src/composables/nodePack/useMissingNodes.ts index f913ae9768..cd2c25abf0 100644 --- a/src/composables/nodePack/useMissingNodes.ts +++ b/src/composables/nodePack/useMissingNodes.ts @@ -2,8 +2,8 @@ import { groupBy } from 'es-toolkit/compat' import { computed, onMounted } from 'vue' import { useWorkflowPacks } from '@/composables/nodePack/useWorkflowPacks' -import { type NodeProperty } from '@/lib/litegraph/src/LGraphNode' -import { LGraphNode } from '@/lib/litegraph/src/litegraph' +import type { NodeProperty } from '@/lib/litegraph/src/LGraphNode' +import type { LGraphNode } from '@/lib/litegraph/src/litegraph' import { app } from '@/scripts/app' import { useComfyManagerStore } from '@/stores/comfyManagerStore' import { useNodeDefStore } from '@/stores/nodeDefStore' diff --git a/src/composables/nodePack/useWorkflowPacks.ts b/src/composables/nodePack/useWorkflowPacks.ts index b6cc19b206..016db08e5f 100644 --- a/src/composables/nodePack/useWorkflowPacks.ts +++ b/src/composables/nodePack/useWorkflowPacks.ts @@ -1,7 +1,7 @@ import { computed, onUnmounted, ref } from 'vue' import { useNodePacks } from '@/composables/nodePack/useNodePacks' -import { LGraphNode } from '@/lib/litegraph/src/litegraph' +import type { LGraphNode } from '@/lib/litegraph/src/litegraph' import { type ComfyWorkflowJSON } from '@/schemas/comfyWorkflowSchema' import { app } from '@/scripts/app' import { useComfyRegistryStore } from '@/stores/comfyRegistryStore' diff --git a/tests-ui/tests/composables/useNodeChatHistory.test.ts b/tests-ui/tests/composables/useNodeChatHistory.test.ts index 0b47fabb6a..4389b8c800 100644 --- a/tests-ui/tests/composables/useNodeChatHistory.test.ts +++ b/tests-ui/tests/composables/useNodeChatHistory.test.ts @@ -1,7 +1,7 @@ import { beforeEach, describe, expect, it, vi } from 'vitest' import { useNodeChatHistory } from '@/composables/node/useNodeChatHistory' -import { LGraphNode } from '@/lib/litegraph/src/litegraph' +import type { LGraphNode } from '@/lib/litegraph/src/litegraph' vi.mock( '@/renderer/extensions/vueNodes/widgets/composables/useChatHistoryWidget',