feat: enhance manager dialog with initial pack id support (#9169)

## Summary
Adds `initialPackId` support to the manager dialog so callers can
deep-link directly to a specific node pack — pre-filling the search
query, switching to packs search mode, and auto-selecting the matching
pack once results load.

## Changes
- **ManagerDialog.vue**: Added `initialPackId` prop; wires it into
`useRegistrySearch` (forces `packs` mode and pre-fills query) and uses
VueUse `until()` to auto-select the target pack and open the right panel
once `resultsWithKeys` is populated (one-shot, never re-triggers). Also
fixes a latent bug where the effective initial tab (resolving the
persisted tab) was not used when determining the initial search mode and
query — previously `initialTab` (the raw prop) was checked directly,
which would produce incorrect pre-fill when no tab prop was passed but a
Missing tab was persisted.
- **useManagerDialog.ts**: Threads `initialPackId` through `show()` into
the dialog props
- **useManagerState.ts**: Exposes `initialPackId` in `openManager`
options and passes it to `managerDialog.show()`; also removes a stale
fallback `show(ManagerTab.All)` call that was redundant for the
legacy-only error path

### Refactor: remove `executionIdUtil.ts` and distribute its functions
- **`getAncestorExecutionIds` / `getParentExecutionIds`** → moved to
`src/types/nodeIdentification.ts`: both are pure `NodeExecutionId`
string operations with no external dependencies, consistent with the
existing `parseNodeExecutionId` / `createNodeExecutionId` helpers
already in that file
- **`buildSubgraphExecutionPaths`** → moved to
`src/platform/workflow/validation/schemas/workflowSchema.ts`: operates
entirely on `ComfyNode[]` and `SubgraphDefinition` (both defined there),
and `isSubgraphDefinition` is already co-located in the same file
- Tests redistributed accordingly: ancestor/parent ID tests into
`nodeIdentification.test.ts`, `buildSubgraphExecutionPaths` tests into
`workflowSchema.test.ts`

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-9169-feat-enhance-manager-dialog-with-initial-pack-id-support-3116d73d365081f7b6a3cbfb2f2755bf)
by [Unito](https://www.unito.io)
This commit is contained in:
jaeone94
2026-02-25 22:23:53 +09:00
committed by GitHub
parent e4b456bb2c
commit 4689581674
9 changed files with 198 additions and 180 deletions

View File

@@ -1,7 +1,11 @@
import fs from 'fs'
import { describe, expect, it } from 'vitest'
import { validateComfyWorkflow } from '@/platform/workflow/validation/schemas/workflowSchema'
import {
buildSubgraphExecutionPaths,
validateComfyWorkflow
} from '@/platform/workflow/validation/schemas/workflowSchema'
import type { ComfyNode } from '@/platform/workflow/validation/schemas/workflowSchema'
import { defaultGraph } from '@/scripts/defaultGraph'
const WORKFLOW_DIR = 'src/platform/workflow/validation/schemas/__fixtures__'
@@ -206,3 +210,67 @@ describe('parseComfyWorkflow', () => {
})
})
})
function node(id: number, type: string): ComfyNode {
return { id, type } as ComfyNode
}
function subgraphDef(id: string, nodes: ComfyNode[]) {
return { id, name: id, nodes, inputNode: {}, outputNode: {} }
}
describe('buildSubgraphExecutionPaths', () => {
it('returns empty map when there are no subgraph definitions', () => {
expect(buildSubgraphExecutionPaths([node(5, 'SomeNode')], [])).toEqual(
new Map()
)
})
it('returns empty map when no root node matches a subgraph type', () => {
const def = subgraphDef('def-A', [])
expect(
buildSubgraphExecutionPaths([node(5, 'UnrelatedNode')], [def])
).toEqual(new Map())
})
it('maps a single subgraph instance to its execution path', () => {
const def = subgraphDef('def-A', [])
const result = buildSubgraphExecutionPaths([node(5, 'def-A')], [def])
expect(result.get('def-A')).toEqual(['5'])
})
it('collects multiple instances of the same subgraph type', () => {
const def = subgraphDef('def-A', [])
const result = buildSubgraphExecutionPaths(
[node(5, 'def-A'), node(10, 'def-A')],
[def]
)
expect(result.get('def-A')).toEqual(['5', '10'])
})
it('builds nested execution paths for subgraphs within subgraphs', () => {
const innerDef = subgraphDef('def-B', [])
const outerDef = subgraphDef('def-A', [node(70, 'def-B')])
const result = buildSubgraphExecutionPaths(
[node(5, 'def-A')],
[outerDef, innerDef]
)
expect(result.get('def-A')).toEqual(['5'])
expect(result.get('def-B')).toEqual(['5:70'])
})
it('does not recurse infinitely on self-referential subgraph definitions', () => {
const cyclicDef = subgraphDef('def-A', [node(70, 'def-A')])
expect(() =>
buildSubgraphExecutionPaths([node(5, 'def-A')], [cyclicDef])
).not.toThrow()
})
it('does not recurse infinitely on mutually cyclic subgraph definitions', () => {
const defA = subgraphDef('def-A', [node(70, 'def-B')])
const defB = subgraphDef('def-B', [node(80, 'def-A')])
expect(() =>
buildSubgraphExecutionPaths([node(5, 'def-A')], [defA, defB])
).not.toThrow()
})
})

View File

@@ -541,3 +541,47 @@ const zNodeData = z.object({
const zComfyApiWorkflow = z.record(zNodeId, zNodeData)
export type ComfyApiWorkflow = z.infer<typeof zComfyApiWorkflow>
/**
* Builds a map from subgraph definition ID to all execution path prefixes
* where that definition is instantiated in the workflow.
*
* "def-A" → ["5", "10"] for each container node instantiating that subgraph definition.
* @knipIgnoreUsedByStackedPR
*/
export function buildSubgraphExecutionPaths(
rootNodes: ComfyNode[],
allSubgraphDefs: unknown[]
): Map<string, string[]> {
const subgraphDefMap = new Map(
allSubgraphDefs.filter(isSubgraphDefinition).map((s) => [s.id, s])
)
const pathMap = new Map<string, string[]>()
const visited = new Set<string>()
const build = (nodes: ComfyNode[], parentPrefix: string) => {
for (const n of nodes ?? []) {
if (typeof n.type !== 'string' || !subgraphDefMap.has(n.type)) continue
const path = parentPrefix ? `${parentPrefix}:${n.id}` : String(n.id)
const existing = pathMap.get(n.type)
if (existing) {
existing.push(path)
} else {
pathMap.set(n.type, [path])
}
if (visited.has(n.type)) continue
visited.add(n.type)
const innerDef = subgraphDefMap.get(n.type)
if (innerDef) {
build(innerDef.nodes, path)
}
visited.delete(n.type)
}
}
build(rootNodes, '')
return pathMap
}