feat: enhance manager dialog with initial pack id support (#9169)

## Summary
Adds `initialPackId` support to the manager dialog so callers can
deep-link directly to a specific node pack — pre-filling the search
query, switching to packs search mode, and auto-selecting the matching
pack once results load.

## Changes
- **ManagerDialog.vue**: Added `initialPackId` prop; wires it into
`useRegistrySearch` (forces `packs` mode and pre-fills query) and uses
VueUse `until()` to auto-select the target pack and open the right panel
once `resultsWithKeys` is populated (one-shot, never re-triggers). Also
fixes a latent bug where the effective initial tab (resolving the
persisted tab) was not used when determining the initial search mode and
query — previously `initialTab` (the raw prop) was checked directly,
which would produce incorrect pre-fill when no tab prop was passed but a
Missing tab was persisted.
- **useManagerDialog.ts**: Threads `initialPackId` through `show()` into
the dialog props
- **useManagerState.ts**: Exposes `initialPackId` in `openManager`
options and passes it to `managerDialog.show()`; also removes a stale
fallback `show(ManagerTab.All)` call that was redundant for the
legacy-only error path

### Refactor: remove `executionIdUtil.ts` and distribute its functions
- **`getAncestorExecutionIds` / `getParentExecutionIds`** → moved to
`src/types/nodeIdentification.ts`: both are pure `NodeExecutionId`
string operations with no external dependencies, consistent with the
existing `parseNodeExecutionId` / `createNodeExecutionId` helpers
already in that file
- **`buildSubgraphExecutionPaths`** → moved to
`src/platform/workflow/validation/schemas/workflowSchema.ts`: operates
entirely on `ComfyNode[]` and `SubgraphDefinition` (both defined there),
and `isSubgraphDefinition` is already co-located in the same file
- Tests redistributed accordingly: ancestor/parent ID tests into
`nodeIdentification.test.ts`, `buildSubgraphExecutionPaths` tests into
`workflowSchema.test.ts`

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-9169-feat-enhance-manager-dialog-with-initial-pack-id-support-3116d73d365081f7b6a3cbfb2f2755bf)
by [Unito](https://www.unito.io)
This commit is contained in:
jaeone94
2026-02-25 22:23:53 +09:00
committed by GitHub
parent e4b456bb2c
commit 4689581674
9 changed files with 198 additions and 180 deletions

View File

@@ -165,7 +165,7 @@
</template>
<script setup lang="ts">
import { whenever } from '@vueuse/core'
import { until, whenever } from '@vueuse/core'
import { merge, stubTrue } from 'es-toolkit/compat'
import type { AutoCompleteOptionSelectEvent } from 'primevue/autocomplete'
import {
@@ -211,8 +211,9 @@ import { useManagerState } from '@/workbench/extensions/manager/composables/useM
import { useComfyManagerStore } from '@/workbench/extensions/manager/stores/comfyManagerStore'
import { ManagerTab } from '@/workbench/extensions/manager/types/comfyManagerTypes'
const { initialTab, onClose } = defineProps<{
const { initialTab, initialPackId, onClose } = defineProps<{
initialTab?: ManagerTab
initialPackId?: string
onClose: () => void
}>()
@@ -347,8 +348,14 @@ const {
sortOptions
} = useRegistrySearch({
initialSortField: initialState.sortField,
initialSearchMode: initialState.searchMode,
initialSearchQuery: initialState.searchQuery
initialSearchMode:
initialPackId && initialTabId !== ManagerTab.Missing
? 'packs'
: initialState.searchMode,
initialSearchQuery:
initialTabId === ManagerTab.Missing
? ''
: (initialPackId ?? initialState.searchQuery)
})
pageNumber.value = 0
@@ -475,6 +482,19 @@ watch(
}
)
// Auto-select the pack matching initialPackId once
if (initialPackId) {
until(resultsWithKeys)
.toMatch((packs) => packs.some((p) => p.id === initialPackId))
.then((packs) => {
const target = packs.find((p) => p.id === initialPackId)
if (target && selectedNodePacks.value.length === 0) {
selectedNodePacks.value = [target]
isRightPanelOpen.value = true
}
})
}
const getLoadingCount = () => {
switch (selectedTab.value?.id) {
case ManagerTab.AllInstalled:

View File

@@ -13,13 +13,14 @@ export function useManagerDialog() {
dialogStore.closeDialog({ key: DIALOG_KEY })
}
function show(initialTab?: ManagerTab) {
function show(initialTab?: ManagerTab, initialPackId?: string) {
dialogService.showLayoutDialog({
key: DIALOG_KEY,
component: ManagerDialog,
props: {
onClose: hide,
initialTab
initialTab,
initialPackId
}
})
}

View File

@@ -8,7 +8,7 @@ import { useSettingsDialog } from '@/platform/settings/composables/useSettingsDi
import { useCommandStore } from '@/stores/commandStore'
import { useSystemStatsStore } from '@/stores/systemStatsStore'
import { useManagerDialog } from '@/workbench/extensions/manager/composables/useManagerDialog'
import { ManagerTab } from '@/workbench/extensions/manager/types/comfyManagerTypes'
import type { ManagerTab } from '@/workbench/extensions/manager/types/comfyManagerTypes'
export enum ManagerUIState {
DISABLED = 'disabled',
@@ -143,6 +143,7 @@ export function useManagerState() {
*/
const openManager = async (options?: {
initialTab?: ManagerTab
initialPackId?: string
legacyCommand?: string
showToastOnLegacyError?: boolean
isLegacyOnly?: boolean
@@ -181,16 +182,14 @@ export function useManagerState() {
case ManagerUIState.NEW_UI:
if (options?.isLegacyOnly) {
// Legacy command is not available in NEW_UI mode
useToastStore().add({
severity: 'error',
summary: t('g.error'),
detail: t('manager.legacyMenuNotAvailable'),
life: 3000
})
await managerDialog.show(ManagerTab.All)
} else {
await managerDialog.show(options?.initialTab)
managerDialog.show(options?.initialTab, options?.initialPackId)
}
break
}