mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-02 20:22:08 +00:00
ops: restrict PyPI publishing to bi-weekly ComfyUI releases (#9948)
## Summary Restrict PyPI publishing of `comfyui-frontend-package` to bi-weekly ComfyUI release cycles only, instead of every nightly version bump. ## Changes - **What**: Move `publish_pypi` job from `release-draft-create.yaml` to `release-biweekly-comfyui.yaml` 1. Removed `publish_pypi` job from `release-draft-create.yaml` (no longer publishes on every merged Release PR) 2. Added `publish-pypi` job to `release-biweekly-comfyui.yaml` with tag polling, build, publish, and PyPI availability confirmation 3. Gated `create-comfyui-pr` on `publish-pypi` success so the ComfyUI requirements bump PR is only created after the package is confirmed available 4. Updated ComfyUI PR body to confirm PyPI availability instead of warning about a pending release PR - **Breaking**: None — nightly releases still create GitHub releases and publish npm types; only PyPI publishing timing changes - **Dependencies**: None ## Review Focus - The `publish-pypi` job uses `if: always() && needs.resolve-version.result == 'success'` to run even when `trigger-release-if-needed` is skipped (tag already exists) - Tag polling (30min timeout) waits for the version bump PR to be merged before building from the tagged commit - PyPI propagation polling (15min timeout) confirms the package is installable before creating the ComfyUI PR Fixes COM-16778 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9948-ops-restrict-PyPI-publishing-to-bi-weekly-ComfyUI-releases-3246d73d36508198b00fcc247ac5b58c) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>
This commit is contained in:
32
.github/workflows/release-draft-create.yaml
vendored
32
.github/workflows/release-draft-create.yaml
vendored
@@ -99,37 +99,6 @@ jobs:
|
||||
${{ needs.build.outputs.is_prerelease == 'true' }}
|
||||
generate_release_notes: true
|
||||
|
||||
publish_pypi:
|
||||
needs: build
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- name: Checkout code
|
||||
uses: actions/checkout@v6
|
||||
- name: Download dist artifact
|
||||
uses: actions/download-artifact@v7
|
||||
with:
|
||||
name: dist-files
|
||||
- name: Set up Python
|
||||
uses: actions/setup-python@v6
|
||||
with:
|
||||
python-version: '3.x'
|
||||
- name: Install build dependencies
|
||||
run: python -m pip install build
|
||||
- name: Setup pypi package
|
||||
run: |
|
||||
mkdir -p comfyui_frontend_package/comfyui_frontend_package/static/
|
||||
cp -r dist/* comfyui_frontend_package/comfyui_frontend_package/static/
|
||||
- name: Build pypi package
|
||||
run: python -m build
|
||||
working-directory: comfyui_frontend_package
|
||||
env:
|
||||
COMFYUI_FRONTEND_VERSION: ${{ needs.build.outputs.version }}
|
||||
- name: Publish pypi package
|
||||
uses: pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e # v1.13.0
|
||||
with:
|
||||
password: ${{ secrets.PYPI_TOKEN }}
|
||||
packages-dir: comfyui_frontend_package/dist
|
||||
|
||||
publish_types:
|
||||
needs: build
|
||||
uses: ./.github/workflows/release-npm-types.yaml
|
||||
@@ -142,7 +111,6 @@ jobs:
|
||||
name: Comment Release Summary
|
||||
needs:
|
||||
- draft_release
|
||||
- publish_pypi
|
||||
- publish_types
|
||||
if: success()
|
||||
runs-on: ubuntu-latest
|
||||
|
||||
Reference in New Issue
Block a user