diff --git a/AGENTS.md b/AGENTS.md index 9938865a9..4659d0761 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -300,6 +300,12 @@ When referencing Comfy-Org repos: Rules for agent-based coding tasks. +### Chrome DevTools MCP + +When using `take_snapshot` to inspect dropdowns, listboxes, or other components with dynamic options: +- Use `verbose: true` to see the full accessibility tree including list items +- Non-verbose snapshots often omit nested options in comboboxes/listboxes + ### Temporary Files - Put planning documents under `/temp/plans/` diff --git a/browser_tests/tests/versionMismatchWarnings.spec.ts b/browser_tests/tests/versionMismatchWarnings.spec.ts index 4b3ff3e30..223770b12 100644 --- a/browser_tests/tests/versionMismatchWarnings.spec.ts +++ b/browser_tests/tests/versionMismatchWarnings.spec.ts @@ -38,6 +38,10 @@ test.describe('Version Mismatch Warnings', () => { test.beforeEach(async ({ comfyPage }) => { await comfyPage.setSetting('Comfy.UseNewMenu', 'Top') + await comfyPage.setSetting( + 'Comfy.VersionCompatibility.DisableWarnings', + false + ) }) test('should show version mismatch warnings when installed version lower than required', async ({ diff --git a/global.d.ts b/global.d.ts index 7f7dd832f..ec455707f 100644 --- a/global.d.ts +++ b/global.d.ts @@ -30,6 +30,7 @@ interface Window { badge?: string } } + dataLayer?: Array> } interface Navigator { diff --git a/index.html b/index.html index 9ff6edb07..1b025c90f 100644 --- a/index.html +++ b/index.html @@ -15,21 +15,62 @@ body { /* Setting it early for background during load */ --bg-color: #202020; + --fg-color: #FFFFFF; } } + html, body { + width: 100%; + height: 100%; + margin: 0; + } body { + display: grid; background-color: var(--bg-color); background-image: var(--bg-img); background-position: center; background-size: cover; background-repeat: no-repeat; } + #vue-app:has(#loading-logo) { + display: contents; + color: var(--fg-color); + & #loading-logo { + place-self: center; + font-size: clamp(2px, 1vw, 6px); + line-height: 1; + overflow: hidden; + max-width: 100vw; + border-radius: 20ch; + } + } + .visually-hidden { + position: absolute; + width: 1px; + height: 1px; + padding: 0; + margin: -1px; + overflow: hidden; + clip-path: inset(50%); + white-space: nowrap; + border: 0; + } -
+
+ Loading ComfyUI... + +
diff --git a/src/AGENTS.md b/src/AGENTS.md index 2778d1b25..276948254 100644 --- a/src/AGENTS.md +++ b/src/AGENTS.md @@ -17,6 +17,7 @@ - Clear public interfaces - Restrict extension access - Clean up subscriptions +- Only expose state/actions that are used externally; keep internal state private ## General Guidelines diff --git a/src/App.vue b/src/App.vue index c3a879b17..7c11c4c7b 100644 --- a/src/App.vue +++ b/src/App.vue @@ -10,7 +10,6 @@