Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-27 09:45:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove LOD from vue nodes (#6950)

Browse Source 
## Summary

Refactor to remove LOD from vue nodes. Also, hide Litegraph LOD settings
in vue nodes to prevent confusion / stale setting. Keep litegraph LOD
the exact same.

## Changes

- **What**: settings, all LOD related code in vue nodes

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6950-fix-remove-LOD-from-vue-nodes-2b76d73d365081568723f8cbc7be7e17)
by [Unito](https://www.unito.io)

---------

Co-authored-by: github-actions <github-actions@github.com>
This commit is contained in:
Simula_r
2025-11-26 11:26:05 -08:00
committed by GitHub
parent 08b256c29d
commit 4b87b1fdc5
27 changed files with 50 additions and 479 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
tests-ui/tests/renderer/extensions/vueNodes/lod/useLOD.test.ts
View File

@@ -1,69 +0,0 @@
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { nextTick, reactive } from 'vue'
import { useLOD } from '@/renderer/extensions/vueNodes/lod/useLOD'
const mockSettingStore = reactive({
get: vi.fn(() => 8)
})
vi.mock('@/platform/settings/settingStore', () => ({
useSettingStore: () => mockSettingStore
}))
describe('useLOD', () => {
beforeEach(() => {
vi.restoreAllMocks()
vi.unstubAllGlobals()
mockSettingStore.get.mockReturnValue(8)
})
it('should calculate isLOD value based on zoom threshold correctly', async () => {
vi.stubGlobal('devicePixelRatio', 1)
const camera = reactive({ z: 1 })
const { isLOD } = useLOD(camera)
await nextTick()
expect(isLOD.value).toBe(false)
camera.z = 0.55
await nextTick()
expect(isLOD.value).toBe(true)
camera.z = 0.87
await nextTick()
expect(isLOD.value).toBe(false)
})
it('should handle a different devicePixelRatio value', async () => {
vi.stubGlobal('devicePixelRatio', 3) //Threshold with 8px minFontsize = 0.19
const camera = reactive({ z: 1 })
const { isLOD } = useLOD(camera)
await nextTick()
expect(isLOD.value).toBe(false)
camera.z = 0.18
await nextTick()
expect(isLOD.value).toBe(true)
})
it('should respond to different minFontSize settings', async () => {
vi.stubGlobal('devicePixelRatio', 1)
mockSettingStore.get.mockReturnValue(16) //Now threshold is 1.14
const camera = reactive({ z: 1 })
const { isLOD } = useLOD(camera)
await nextTick()
expect(isLOD.value).toBe(true)
camera.z = 1.15
await nextTick()
expect(isLOD.value).toBe(false)
})
})