diff --git a/.github/actions/setup-frontend/action.yaml b/.github/actions/setup-frontend/action.yaml index c4d5d4eedf..b10d6807cb 100644 --- a/.github/actions/setup-frontend/action.yaml +++ b/.github/actions/setup-frontend/action.yaml @@ -19,7 +19,7 @@ runs: - name: Setup Node.js uses: actions/setup-node@v6 with: - node-version: 'lts/*' + node-version-file: '.nvmrc' cache: 'pnpm' cache-dependency-path: './pnpm-lock.yaml' diff --git a/.github/workflows/ci-lint-format.yaml b/.github/workflows/ci-lint-format.yaml index 8de5d46b97..157bd576d2 100644 --- a/.github/workflows/ci-lint-format.yaml +++ b/.github/workflows/ci-lint-format.yaml @@ -61,6 +61,22 @@ jobs: git commit -m "[automated] Apply ESLint and Oxfmt fixes" git push + - name: Fail for fork PRs with unfixed lint/format issues + if: steps.verify-changed-files.outputs.changed == 'true' && github.event.pull_request.head.repo.full_name != github.repository + run: | + echo "::error::Linting/formatting issues found. Since this PR is from a fork, auto-fix cannot be applied automatically." + echo "" + echo "Please run these commands locally and push the changes:" + echo " pnpm lint:fix" + echo " pnpm stylelint:fix" + echo " pnpm format" + echo "" + echo "Or set up pre-commit hooks to automatically format on every commit:" + echo " pnpm prepare" + echo "" + echo "See CONTRIBUTING.md for more details." + exit 1 + - name: Final validation run: | pnpm lint @@ -84,16 +100,3 @@ jobs: repo: context.repo.repo, body: '## 🔧 Auto-fixes Applied\n\nThis PR has been automatically updated to fix linting and formatting issues.\n\n**⚠️ Important**: Your local branch is now behind. Run `git pull` before making additional changes to avoid conflicts.\n\n### Changes made:\n- ESLint auto-fixes\n- Oxfmt formatting' }) - - - name: Comment on PR about manual fix needed - if: steps.verify-changed-files.outputs.changed == 'true' && github.event.pull_request.head.repo.full_name != github.repository - continue-on-error: true - uses: actions/github-script@v8 - with: - script: | - github.rest.issues.createComment({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - body: '## ⚠️ Linting/Formatting Issues Found\n\nThis PR has linting or formatting issues that need to be fixed.\n\n**Since this PR is from a fork, auto-fix cannot be applied automatically.**\n\n### Option 1: Set up pre-commit hooks (recommended)\nRun this once to automatically format code on every commit:\n```bash\npnpm prepare\n```\n\n### Option 2: Fix manually\nRun these commands and push the changes:\n```bash\npnpm lint:fix\npnpm format\n```\n\nSee [CONTRIBUTING.md](https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/CONTRIBUTING.md#git-pre-commit-hooks) for more details.' - })