Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-26 09:19:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "fix: use selectFirstNodeByTitles to avoid strict mode violations"

Browse Source 
This reverts commit 40961820d0.
This commit is contained in:
bymyself
2026-01-31 20:58:18 -08:00
parent 40961820d0
commit 4d11359bea
6 changed files with 21 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
browser_tests/tests/propertiesPanel/propertiesPanelTabs.spec.ts
View File

@@ -67,10 +67,7 @@ test.describe('Properties panel tab navigation', { tag: ['@ui'] }, () => {
await expect(propertiesPanel.getTab('Settings')).toBeVisible()
await expect(propertiesPanel.getTab('Nodes')).not.toBeVisible()
await comfyPage.selectFirstNodeByTitles([
'KSampler',
'CLIP Text Encode (Prompt)'
])
await comfyPage.selectNodes(['KSampler', 'CLIP Text Encode (Prompt)'])
await expect(propertiesPanel.getTab('Parameters')).toBeVisible()
await expect(propertiesPanel.getTab('Settings')).toBeVisible()
await expect(propertiesPanel.getTab('Info')).not.toBeVisible()
@@ -80,13 +77,10 @@ test.describe('Properties panel tab navigation', { tag: ['@ui'] }, () => {
test('first tab updates for multiple selection', async ({ comfyPage }) => {
const { propertiesPanel } = comfyPage
await comfyPage.selectFirstNodeByTitles(['KSampler'])
await comfyPage.selectNodes(['KSampler'])
await expect(propertiesPanel.getTab('Parameters')).toBeVisible()
await comfyPage.selectFirstNodeByTitles([
'KSampler',
'CLIP Text Encode (Prompt)'
])
await comfyPage.selectNodes(['KSampler', 'CLIP Text Encode (Prompt)'])
const firstTab = propertiesPanel.tabList.locator('[role="tab"]').first()
await expect(firstTab).toBeVisible()
})
@@ -98,10 +92,10 @@ test.describe('Properties panel tab navigation', { tag: ['@ui'] }, () => {
}) => {
const { propertiesPanel } = comfyPage
await comfyPage.selectFirstNodeByTitles(['KSampler'])
await comfyPage.selectNodes(['KSampler'])
await propertiesPanel.clickTab('Settings')
await comfyPage.selectFirstNodeByTitles(['CLIP Text Encode (Prompt)'])
await comfyPage.selectNodes(['CLIP Text Encode (Prompt)'])
await expect(propertiesPanel.getTab('Settings')).toBeVisible()
})
@@ -111,13 +105,10 @@ test.describe('Properties panel tab navigation', { tag: ['@ui'] }, () => {
}) => {
const { propertiesPanel } = comfyPage
await comfyPage.selectFirstNodeByTitles(['KSampler'])
await comfyPage.selectNodes(['KSampler'])
await propertiesPanel.clickTab('Info')
await comfyPage.selectFirstNodeByTitles([
'KSampler',
'CLIP Text Encode (Prompt)'
])
await comfyPage.selectNodes(['KSampler', 'CLIP Text Encode (Prompt)'])
await expect(propertiesPanel.getTab('Info')).not.toBeVisible()
const firstTab = propertiesPanel.tabList.locator('[role="tab"]').first()