mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-24 08:19:51 +00:00
refactor: change setup-frontend action to use include_build_step (default false)
- Renamed parameter from skip_build to include_build_step - Changed default from 'false' to 'false' (building now opt-in) - Updated all workflow usages to explicitly set include_build_step: 'true' where building is needed - Removed explicit parameter for workflows that don't need building As suggested by @DrJKL in PR review
This commit is contained in:
8
.github/actions/setup-frontend/action.yml
vendored
8
.github/actions/setup-frontend/action.yml
vendored
@@ -1,8 +1,8 @@
|
||||
name: Setup ComfyUI Frontend
|
||||
description: 'Install nodejs/pnpm/dependencies and build ComfyUI_frontend'
|
||||
description: 'Install nodejs/pnpm/dependencies and optionally build ComfyUI_frontend'
|
||||
inputs:
|
||||
skip_build:
|
||||
description: 'Skip building the frontend, just install dependencies, useful for CI jobs that do not need a built frontend or already have a cached build'
|
||||
include_build_step:
|
||||
description: 'Include the build step to build the frontend. Set to true for workflows that need a built frontend'
|
||||
required: false
|
||||
default: 'false'
|
||||
runs:
|
||||
@@ -40,6 +40,6 @@ runs:
|
||||
run: pnpm install --frozen-lockfile
|
||||
|
||||
- name: Build ComfyUI_frontend
|
||||
if: ${{ inputs.skip_build != 'true' }}
|
||||
if: ${{ inputs.include_build_step == 'true' }}
|
||||
shell: bash
|
||||
run: pnpm build
|
||||
|
||||
8
.github/workflows/tests-ci.yaml
vendored
8
.github/workflows/tests-ci.yaml
vendored
@@ -24,7 +24,7 @@ jobs:
|
||||
- name: Setup frontend
|
||||
uses: ./.github/actions/setup-frontend
|
||||
with:
|
||||
not_build: 'false'
|
||||
include_build_step: 'true'
|
||||
- name: Setup Playwright
|
||||
uses: ./.github/actions/setup-playwright # Setup Playwright and cache browsers
|
||||
|
||||
@@ -65,8 +65,6 @@ jobs:
|
||||
uses: ./.github/actions/setup-comfyui-server
|
||||
- name: Setup nodejs, pnpm, reuse built frontend
|
||||
uses: ./.github/actions/setup-frontend
|
||||
with:
|
||||
not_build: 'true'
|
||||
- name: Setup Playwright
|
||||
uses: ./.github/actions/setup-playwright
|
||||
|
||||
@@ -112,8 +110,6 @@ jobs:
|
||||
uses: ./.github/actions/setup-comfyui-server
|
||||
- name: Setup nodejs, pnpm, reuse built frontend
|
||||
uses: ./.github/actions/setup-frontend
|
||||
with:
|
||||
not_build: 'true'
|
||||
- name: Setup Playwright
|
||||
uses: ./.github/actions/setup-playwright
|
||||
|
||||
@@ -148,8 +144,6 @@ jobs:
|
||||
# Setup Test Environment, we only need playwright to merge reports
|
||||
- name: Setup frontend
|
||||
uses: ./.github/actions/setup-frontend
|
||||
with:
|
||||
not_build: 'true'
|
||||
- name: Setup Playwright
|
||||
uses: ./.github/actions/setup-playwright
|
||||
|
||||
|
||||
@@ -32,7 +32,7 @@ jobs:
|
||||
- name: Setup frontend
|
||||
uses: ./.github/actions/setup-frontend
|
||||
with:
|
||||
not_build: 'false'
|
||||
include_build_step: 'true'
|
||||
- name: Setup Playwright
|
||||
uses: ./.github/actions/setup-playwright
|
||||
|
||||
|
||||
2
.github/workflows/update-locales.yaml
vendored
2
.github/workflows/update-locales.yaml
vendored
@@ -23,7 +23,7 @@ jobs:
|
||||
- name: Setup ComfyUI Frontend
|
||||
uses: ./.github/actions/setup-frontend
|
||||
with:
|
||||
not_build: 'false'
|
||||
include_build_step: 'true'
|
||||
- name: Setup Playwright
|
||||
uses: ./.github/actions/setup-playwright
|
||||
|
||||
|
||||
@@ -21,7 +21,7 @@ jobs:
|
||||
- name: Setup frontend
|
||||
uses: ./.github/actions/setup-frontend
|
||||
with:
|
||||
not_build: 'false'
|
||||
include_build_step: 'true'
|
||||
- name: Setup Playwright
|
||||
uses: ./.github/actions/setup-playwright
|
||||
|
||||
|
||||
Reference in New Issue
Block a user