From 542e1c1f59010384d5f5e8b8da34f64fdaad68ed Mon Sep 17 00:00:00 2001
From: Chenlei Hu <chenlei.hu@mail.utoronto.ca>
Date: Fri, 26 Jul 2024 16:25:12 -0400
Subject: [PATCH] Move sidebar y-axis overflow style to container (#236)

---
 src/components/sidebar/SideToolBar.vue        | 37 ++++++++++---------
 .../sidebar/tabs/QueueSideBarTab.vue          |  5 ---
 2 files changed, 20 insertions(+), 22 deletions(-)

diff --git a/src/components/sidebar/SideToolBar.vue b/src/components/sidebar/SideToolBar.vue
index caaebda82..868148357 100644
--- a/src/components/sidebar/SideToolBar.vue
+++ b/src/components/sidebar/SideToolBar.vue
@@ -15,23 +15,21 @@
       </div>
     </nav>
   </teleport>
-  <div v-if="!selectedTab"></div>
-  <component
-    v-else-if="selectedTab.type === 'vue'"
-    :is="selectedTab.component"
-  />
-  <div
-    v-else
-    :ref="
-      (el) => {
-        if (el)
-          mountCustomTab(
-            selectedTab as CustomSidebarTabExtension,
-            el as HTMLElement
-          )
-      }
-    "
-  ></div>
+  <div v-if="selectedTab" class="sidebar-content-container">
+    <component v-if="selectedTab.type === 'vue'" :is="selectedTab.component" />
+    <div
+      v-else
+      :ref="
+        (el) => {
+          if (el)
+            mountCustomTab(
+              selectedTab as CustomSidebarTabExtension,
+              el as HTMLElement
+            )
+        }
+      "
+    ></div>
+  </div>
 </template>
 
 <script setup lang="ts">
@@ -94,4 +92,9 @@ onBeforeUnmount(() => {
   align-self: flex-end;
   margin-top: auto;
 }
+
+.sidebar-content-container {
+  height: 100%;
+  overflow-y: auto;
+}
 </style>
diff --git a/src/components/sidebar/tabs/QueueSideBarTab.vue b/src/components/sidebar/tabs/QueueSideBarTab.vue
index f49dca389..577db59f7 100644
--- a/src/components/sidebar/tabs/QueueSideBarTab.vue
+++ b/src/components/sidebar/tabs/QueueSideBarTab.vue
@@ -168,9 +168,4 @@ onMounted(() => {
 .queue-time-cell-content {
   width: fit-content;
 }
-
-.queue-table {
-  height: 100%;
-  overflow-y: auto;
-}
 </style>