From 596c51d1efade9efd9d793d07605352f77315885 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 30 Jul 2025 00:08:06 -0700 Subject: [PATCH] [fix] Fix "Require confirmation before clearing workflow" setting not working (#4587) Co-authored-by: Claude --- browser_tests/tests/groupNode.spec.ts | 5 +++++ src/composables/useCoreCommands.ts | 2 +- src/schemas/apiSchema.ts | 1 - 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/browser_tests/tests/groupNode.spec.ts b/browser_tests/tests/groupNode.spec.ts index 0e4d7c38a5..ae1ee505fe 100644 --- a/browser_tests/tests/groupNode.spec.ts +++ b/browser_tests/tests/groupNode.spec.ts @@ -264,10 +264,15 @@ test.describe('Group Node', () => { test('Copies and pastes group node after clearing workflow', async ({ comfyPage }) => { + // Set setting + await comfyPage.setSetting('Comfy.ConfirmClear', false) + + // Clear workflow await comfyPage.menu.topbar.triggerTopbarCommand([ 'Edit', 'Clear Workflow' ]) + await comfyPage.ctrlV() await verifyNodeLoaded(comfyPage, 1) }) diff --git a/src/composables/useCoreCommands.ts b/src/composables/useCoreCommands.ts index 055d85b0a4..54eaa2a321 100644 --- a/src/composables/useCoreCommands.ts +++ b/src/composables/useCoreCommands.ts @@ -168,7 +168,7 @@ export function useCoreCommands(): ComfyCommand[] { function: () => { const settingStore = useSettingStore() if ( - !settingStore.get('Comfy.ComfirmClear') || + !settingStore.get('Comfy.ConfirmClear') || confirm('Clear workflow?') ) { app.clean() diff --git a/src/schemas/apiSchema.ts b/src/schemas/apiSchema.ts index 86e7b28166..f5b62b3b80 100644 --- a/src/schemas/apiSchema.ts +++ b/src/schemas/apiSchema.ts @@ -468,7 +468,6 @@ const zSettings = z.object({ 'LiteGraph.Canvas.LowQualityRenderingZoomThreshold': z.number(), 'Comfy.Canvas.SelectionToolbox': z.boolean(), 'LiteGraph.Node.TooltipDelay': z.number(), - 'Comfy.ComfirmClear': z.boolean(), 'LiteGraph.ContextMenu.Scaling': z.boolean(), 'LiteGraph.Reroute.SplineOffset': z.number(), 'Comfy.Toast.DisableReconnectingToast': z.boolean(),