From 618b451f1e3db1f3caa0592b54009f344dccd862 Mon Sep 17 00:00:00 2001 From: Chenlei Hu Date: Fri, 13 Dec 2024 14:13:56 -0800 Subject: [PATCH] [test] Stricter locator matching on workflows sidebar elements (#1905) * [test] Stricter locator matching on workflows sidebar elements * nit --- .../fixtures/components/SidebarTab.ts | 20 +++++++++++-------- .../sidebar/tabs/WorkflowsSidebarTab.vue | 2 +- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/browser_tests/fixtures/components/SidebarTab.ts b/browser_tests/fixtures/components/SidebarTab.ts index 836694be9..64e83751c 100644 --- a/browser_tests/fixtures/components/SidebarTab.ts +++ b/browser_tests/fixtures/components/SidebarTab.ts @@ -85,32 +85,36 @@ export class WorkflowsSidebarTab extends SidebarTab { super(page, 'workflows') } + get root() { + return this.page.locator('.workflows-sidebar-tab') + } + get browseGalleryButton() { - return this.page.locator('.browse-templates-button') + return this.root.locator('.browse-templates-button') } get newBlankWorkflowButton() { - return this.page.locator('.new-blank-workflow-button') + return this.root.locator('.new-blank-workflow-button') } get openWorkflowButton() { - return this.page.locator('.open-workflow-button') + return this.root.locator('.open-workflow-button') } async getOpenedWorkflowNames() { - return await this.page + return await this.root .locator('.comfyui-workflows-open .node-label') .allInnerTexts() } async getActiveWorkflowName() { - return await this.page + return await this.root .locator('.comfyui-workflows-open .p-tree-node-selected .node-label') .innerText() } async getTopLevelSavedWorkflowNames() { - return await this.page + return await this.root .locator('.comfyui-workflows-browse .node-label') .allInnerTexts() } @@ -122,13 +126,13 @@ export class WorkflowsSidebarTab extends SidebarTab { } getOpenedItem(name: string) { - return this.page.locator('.comfyui-workflows-open .node-label', { + return this.root.locator('.comfyui-workflows-open .node-label', { hasText: name }) } getPersistedItem(name: string) { - return this.page.locator('.comfyui-workflows-browse .node-label', { + return this.root.locator('.comfyui-workflows-browse .node-label', { hasText: name }) } diff --git a/src/components/sidebar/tabs/WorkflowsSidebarTab.vue b/src/components/sidebar/tabs/WorkflowsSidebarTab.vue index 61100f5d7..42fcd6a62 100644 --- a/src/components/sidebar/tabs/WorkflowsSidebarTab.vue +++ b/src/components/sidebar/tabs/WorkflowsSidebarTab.vue @@ -1,7 +1,7 @@