From 668500cfa59b5b4150ad76e441e958971bcd1684 Mon Sep 17 00:00:00 2001 From: filtered <176114999+webfiltered@users.noreply.github.com> Date: Mon, 15 Sep 2025 12:35:59 +1000 Subject: [PATCH] Fix light_theme changes default node background (#5562) * Fix light_theme changes default node background This is an issue where the background of nodes which have no background set were being lightened by this switch, when they should be skipped. Went unnoticed because the only theme using this was the built-in light theme, which used white for node backgrounds anyway. * Fix bypassed nodes * nit * Revert "nit" This reverts commit e22f03a0e99a6279726ead5b1934d655ec0b45fb. * Revert "Fix bypassed nodes" This reverts commit 6121634c099e0f64929de99b109ae62bb4bc8d25. * Revert "Fix light_theme changes default node background" This reverts commit 3206973e5a19f0cb3bcf93cc641b7ff70e2f055c. * Fix opacity not rendered to default nodes Also causes bypassed nodes in light mode to once again render in light pink (again). Not sure when this regression occurred. * Revert "Fix opacity not rendered to default nodes" This reverts commit da65a1dbaf92bab520dadc867b0897ff29d8d287. * Fix backgrounds not adjusting for light mode --- src/scripts/app.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scripts/app.ts b/src/scripts/app.ts index 6c1114a268..ae0ad8ccda 100644 --- a/src/scripts/app.ts +++ b/src/scripts/app.ts @@ -650,7 +650,7 @@ export class ComfyApp { if (opacity) adjustments.opacity = opacity if (useColorPaletteStore().completedActivePalette.light_theme) { - adjustments.lightness = 0.5 + if (old_bgcolor) adjustments.lightness = 0.5 // Lighten title bar of colored nodes on light theme if (old_color) {