From 69ef8ff8040d07fc8e54db993cdaa407f10c76fa Mon Sep 17 00:00:00 2001 From: Johnpaul Date: Thu, 29 Jan 2026 03:09:44 +0100 Subject: [PATCH] fix: build frontend with IS_NIGHTLY=true in CI workflows The test was failing because the frontend was built without IS_NIGHTLY=true, so the compiled code had __IS_NIGHTLY__ set to false. Setting IS_NIGHTLY=true during test runtime didn't affect the already-compiled code. This fix ensures the frontend is built with IS_NIGHTLY=true during the build phase in the CI workflows, so the compiled code will have the correct value. --- .github/workflows/ci-tests-e2e.yaml | 2 ++ .github/workflows/pr-update-playwright-expectations.yaml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/ci-tests-e2e.yaml b/.github/workflows/ci-tests-e2e.yaml index daa946727..61798a4ff 100644 --- a/.github/workflows/ci-tests-e2e.yaml +++ b/.github/workflows/ci-tests-e2e.yaml @@ -22,6 +22,8 @@ jobs: uses: ./.github/actions/setup-frontend with: include_build_step: true + env: + IS_NIGHTLY: 'true' # Upload only built dist/ (containerized test jobs will pnpm install without cache) - name: Upload built frontend diff --git a/.github/workflows/pr-update-playwright-expectations.yaml b/.github/workflows/pr-update-playwright-expectations.yaml index 75e6acf1c..a56376879 100644 --- a/.github/workflows/pr-update-playwright-expectations.yaml +++ b/.github/workflows/pr-update-playwright-expectations.yaml @@ -63,6 +63,8 @@ jobs: uses: ./.github/actions/setup-frontend with: include_build_step: true + env: + IS_NIGHTLY: 'true' # Upload built dist/ (containerized test jobs will pnpm install without cache) - name: Upload built frontend