From 6ab92f28dbd71cbfe850b75fc8e43f0ffae79aac Mon Sep 17 00:00:00 2001
From: Chenlei Hu <chenlei.hu@mail.utoronto.ca>
Date: Tue, 27 Aug 2024 09:58:09 -0400
Subject: [PATCH] Fix dialog maximization (#652)

---
 src/components/dialog/GlobalDialog.vue | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/src/components/dialog/GlobalDialog.vue b/src/components/dialog/GlobalDialog.vue
index 16459137f..d0359551c 100644
--- a/src/components/dialog/GlobalDialog.vue
+++ b/src/components/dialog/GlobalDialog.vue
@@ -7,9 +7,10 @@
     closeOnEscape
     dismissableMask
     :maximizable="maximizable"
+    :maximized="maximized"
     @hide="dialogStore.closeDialog"
-    @maximize="maximized = true"
-    @unmaximize="maximized = false"
+    @maximize="onMaximize"
+    @unmaximize="onUnmaximize"
   >
     <template #header>
       <component
@@ -29,10 +30,19 @@ import { useDialogStore } from '@/stores/dialogStore'
 import Dialog from 'primevue/dialog'
 
 const dialogStore = useDialogStore()
-const maximizable = dialogStore.props.maximizable ?? false
+const maximizable = computed(() => dialogStore.props.maximizable ?? false)
 const maximized = ref(false)
+
+const onMaximize = () => {
+  maximized.value = true
+}
+
+const onUnmaximize = () => {
+  maximized.value = false
+}
+
 const contentProps = computed(() => ({
   ...dialogStore.props,
-  ...(dialogStore.props.maximizable ? { maximized } : {})
+  maximized: maximized.value
 }))
 </script>