Fix unrecognized bookmark node crash the node library sidebar (#614)

* Add playwright test

* nit
This commit is contained in:
Chenlei Hu
2024-08-24 11:58:14 -04:00
committed by GitHub
parent 2fdaabd2c9
commit 6c557eaa58
3 changed files with 79 additions and 29 deletions

View File

@@ -148,14 +148,20 @@ const toggleBookmark = (bookmark: string) => {
}
}
const bookmarkedRoot = computed<TreeNode>(() => {
const bookmarkNodes = bookmarks.value.map((bookmark: string) => {
const parts = bookmark.split('/')
const nodeName = parts.pop()
const category = parts.join('/')
const nodeDef = _.clone(nodeDefStore.nodeDefsByDisplayName[nodeName])
nodeDef.category = category
return nodeDef
})
const bookmarkNodes = bookmarks.value
.map((bookmark: string) => {
const parts = bookmark.split('/')
const displayName = parts.pop()
const category = parts.join('/')
const srcNodeDef = nodeDefStore.nodeDefsByDisplayName[displayName]
if (!srcNodeDef) {
return null
}
const nodeDef = _.clone(srcNodeDef)
nodeDef.category = category
return nodeDef
})
.filter((nodeDef) => nodeDef !== null)
return buildNodeDefTree(bookmarkNodes)
})