Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-24 08:19:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: use createTestingPinia instead of createPinia (#8376)

Browse Source 
Replace \createPinia\ with \createTestingPinia({ stubActions: false })\
from \@pinia/testing\ across 45 test files for proper test isolation.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8376-test-use-createTestingPinia-instead-of-createPinia-2f66d73d36508137a9f0daffcddc86f7)
by [Unito](https://www.unito.io)

Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Alexander Brown
2026-01-28 22:21:38 -08:00
committed by GitHub
parent 3b5d124029
commit 6ce60a11a4
46 changed files with 139 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/workbench/extensions/manager/components/manager/NodeConflictDialogContent.test.ts
View File

@@ -1,5 +1,6 @@
import { mount } from '@vue/test-utils'
import { createPinia, setActivePinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import { setActivePinia } from 'pinia'
import Button from '@/components/ui/button/Button.vue'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { computed, ref } from 'vue'
@@ -44,11 +45,11 @@ vi.mock(
)
describe('NodeConflictDialogContent', () => {
let pinia: ReturnType<typeof createPinia>
let pinia: ReturnType<typeof createTestingPinia>
beforeEach(() => {
vi.clearAllMocks()
pinia = createPinia()
pinia = createTestingPinia({ stubActions: false })
setActivePinia(pinia)
// Reset mock data
mockConflictData.value = []

4
src/workbench/extensions/manager/components/manager/PackVersionBadge.test.ts
View File

@@ -1,6 +1,6 @@
import type { VueWrapper } from '@vue/test-utils'
import { mount } from '@vue/test-utils'
import { createPinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import PrimeVue from 'primevue/config'
import Tooltip from 'primevue/tooltip'
import { beforeEach, describe, expect, it, vi } from 'vitest'
@@ -89,7 +89,7 @@ describe('PackVersionBadge', () => {
...props
},
global: {
plugins: [PrimeVue, createPinia(), i18n],
plugins: [PrimeVue, createTestingPinia({ stubActions: false }), i18n],
directives: {
tooltip: Tooltip
},

4
src/workbench/extensions/manager/components/manager/PackVersionSelectorPopover.test.ts
View File

@@ -1,6 +1,6 @@
import type { VueWrapper } from '@vue/test-utils'
import { mount } from '@vue/test-utils'
import { createPinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import Button from '@/components/ui/button/Button.vue'
import PrimeVue from 'primevue/config'
import Listbox from 'primevue/listbox'
@@ -115,7 +115,7 @@ describe('PackVersionSelectorPopover', () => {
...props
},
global: {
plugins: [PrimeVue, createPinia(), i18n],
plugins: [PrimeVue, createTestingPinia({ stubActions: false }), i18n],
components: {
Listbox,
VerifiedIcon,

4
src/workbench/extensions/manager/components/manager/button/PackEnableToggle.test.ts
View File

@@ -1,6 +1,6 @@
import type { VueWrapper } from '@vue/test-utils'
import { mount } from '@vue/test-utils'
import { createPinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import PrimeVue from 'primevue/config'
import ToggleSwitch from 'primevue/toggleswitch'
import { beforeEach, describe, expect, it, vi } from 'vitest'
@@ -81,7 +81,7 @@ describe('PackEnableToggle', () => {
...props
},
global: {
plugins: [PrimeVue, createPinia(), i18n]
plugins: [PrimeVue, createTestingPinia({ stubActions: false }), i18n]
}
})
}

4
src/workbench/extensions/manager/components/manager/packCard/PackCardFooter.test.ts
View File

@@ -1,6 +1,6 @@
import type { VueWrapper } from '@vue/test-utils'
import { mount } from '@vue/test-utils'
import { createPinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import PrimeVue from 'primevue/config'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { ref } from 'vue'
@@ -73,7 +73,7 @@ describe('PackCardFooter', () => {
...props
},
global: {
plugins: [PrimeVue, createPinia(), i18n],
plugins: [PrimeVue, createTestingPinia({ stubActions: false }), i18n],
provide: {
[IsInstallingKey]: ref(false)
}

4
src/workbench/extensions/manager/components/manager/skeleton/PackCardGridSkeleton.test.ts
View File

@@ -1,6 +1,6 @@
import type { VueWrapper } from '@vue/test-utils'
import { mount } from '@vue/test-utils'
import { createPinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import PrimeVue from 'primevue/config'
import { describe, expect, it } from 'vitest'
import { nextTick } from 'vue'
@@ -32,7 +32,7 @@ describe('GridSkeleton', () => {
...props
},
global: {
plugins: [PrimeVue, createPinia(), i18n],
plugins: [PrimeVue, createTestingPinia({ stubActions: false }), i18n],
stubs: {
PackCardSkeleton: true
}

5
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.test.ts
View File

@@ -1,4 +1,5 @@
import { createPinia, setActivePinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import { setActivePinia } from 'pinia'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { ref } from 'vue'
@@ -36,7 +37,7 @@ describe('usePacksSelection', () => {
beforeEach(() => {
vi.clearAllMocks()
const pinia = createPinia()
const pinia = createTestingPinia({ stubActions: false })
setActivePinia(pinia)
managerStore = useComfyManagerStore()

5
src/workbench/extensions/manager/composables/nodePack/usePacksStatus.test.ts
View File

@@ -1,4 +1,5 @@
import { createPinia, setActivePinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import { setActivePinia } from 'pinia'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { ref } from 'vue'
@@ -48,7 +49,7 @@ describe('usePacksStatus', () => {
beforeEach(() => {
vi.clearAllMocks()
setActivePinia(createPinia())
setActivePinia(createTestingPinia({ stubActions: false }))
conflictDetectionStore = useConflictDetectionStore()
})

5
src/workbench/extensions/manager/composables/useConflictAcknowledgment.test.ts
View File

@@ -1,10 +1,11 @@
import { createPinia, setActivePinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import { setActivePinia } from 'pinia'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
describe('useConflictAcknowledgment', () => {
beforeEach(() => {
// Set up Pinia for each test
setActivePinia(createPinia())
setActivePinia(createTestingPinia({ stubActions: false }))
// Clear localStorage before each test
localStorage.clear()
// Reset modules to ensure fresh state

7
src/workbench/extensions/manager/composables/useConflictDetection.test.ts
View File

@@ -1,4 +1,5 @@
import { createPinia, setActivePinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import { setActivePinia } from 'pinia'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { computed, ref } from 'vue'
@@ -114,7 +115,7 @@ vi.mock('@/workbench/extensions/manager/composables/useManagerState', () => ({
}))
describe('useConflictDetection', () => {
let pinia: ReturnType<typeof createPinia>
let pinia: ReturnType<typeof createTestingPinia>
const mockComfyManagerService = {
getImportFailInfoBulk: vi.fn(),
@@ -221,7 +222,7 @@ describe('useConflictDetection', () => {
beforeEach(() => {
vi.clearAllMocks()
pinia = createPinia()
pinia = createTestingPinia({ stubActions: false })
setActivePinia(pinia)
// Setup mocks

5
src/workbench/extensions/manager/composables/useImportFailedDetection.test.ts
View File

@@ -1,4 +1,5 @@
import { createPinia, setActivePinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import { setActivePinia } from 'pinia'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { computed, ref } from 'vue'
@@ -31,7 +32,7 @@ describe('useImportFailedDetection', () => {
let mockDialogService: ReturnType<typeof dialogService.useDialogService>
beforeEach(() => {
setActivePinia(createPinia())
setActivePinia(createTestingPinia({ stubActions: false }))
mockComfyManagerStore = {
isPackInstalled: vi.fn()

5
src/workbench/extensions/manager/stores/comfyManagerStore.test.ts
View File

@@ -1,4 +1,5 @@
import { createPinia, setActivePinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import { setActivePinia } from 'pinia'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { nextTick, ref } from 'vue'
@@ -72,7 +73,7 @@ describe('useComfyManagerStore', () => {
}
beforeEach(() => {
setActivePinia(createPinia())
setActivePinia(createTestingPinia({ stubActions: false }))
vi.clearAllMocks()
mockManagerService = {
isLoading: ref(false),

5
src/workbench/extensions/manager/stores/conflictDetectionStore.test.ts
View File

@@ -1,4 +1,5 @@
import { createPinia, setActivePinia } from 'pinia'
import { createTestingPinia } from '@pinia/testing'
import { setActivePinia } from 'pinia'
import { beforeEach, describe, expect, it } from 'vitest'
import { useConflictDetectionStore } from '@/workbench/extensions/manager/stores/conflictDetectionStore'
@@ -6,7 +7,7 @@ import type { ConflictDetectionResult } from '@/workbench/extensions/manager/typ
describe('useConflictDetectionStore', () => {
beforeEach(() => {
setActivePinia(createPinia())
setActivePinia(createTestingPinia({ stubActions: false }))
})
const mockConflictedPackages: ConflictDetectionResult[] = [