[System Pop Up] Add setting to disable version update notifications (#4388)

browser_tests/tests/releaseNotifications.spec.ts

@@ -130,4 +130,239 @@ test.describe('Release Notifications', () => {
       whatsNewSection.locator('text=No recent releases')
     ).toBeVisible()
   })
+
+  test('should hide "What\'s New" section when notifications are disabled', async ({
+    comfyPage
+  }) => {
+    // Disable version update notifications
+    await comfyPage.setSetting('Comfy.Notification.ShowVersionUpdates', false)
+
+    // Mock release API with test data
+    await comfyPage.page.route('**/releases**', async (route) => {
+      const url = route.request().url()
+      if (
+        url.includes('api.comfy.org') ||
+        url.includes('stagingapi.comfy.org')
+      ) {
+        await route.fulfill({
+          status: 200,
+          contentType: 'application/json',
+          body: JSON.stringify([
+            {
+              id: 1,
+              project: 'comfyui',
+              version: 'v0.3.44',
+              attention: 'high',
+              content: '## New Features\n\n- Added awesome feature',
+              published_at: new Date().toISOString()
+            }
+          ])
+        })
+      } else {
+        await route.continue()
+      }
+    })
+
+    await comfyPage.setup({ mockReleases: false })
+
+    // Open help center
+    const helpCenterButton = comfyPage.page.locator('.comfy-help-center-btn')
+    await helpCenterButton.waitFor({ state: 'visible' })
+    await helpCenterButton.click()
+
+    // Verify help center menu appears
+    const helpMenu = comfyPage.page.locator('.help-center-menu')
+    await expect(helpMenu).toBeVisible()
+
+    // Verify "What's New?" section is hidden
+    const whatsNewSection = comfyPage.page.locator('.whats-new-section')
+    await expect(whatsNewSection).not.toBeVisible()
+
+    // Should not show any popups or toasts
+    await expect(comfyPage.page.locator('.whats-new-popup')).not.toBeVisible()
+    await expect(
+      comfyPage.page.locator('.release-notification-toast')
+    ).not.toBeVisible()
+  })
+
+  test('should not make API calls when notifications are disabled', async ({
+    comfyPage
+  }) => {
+    // Disable version update notifications
+    await comfyPage.setSetting('Comfy.Notification.ShowVersionUpdates', false)
+
+    // Track API calls
+    let apiCallCount = 0
+    await comfyPage.page.route('**/releases**', async (route) => {
+      const url = route.request().url()
+      if (
+        url.includes('api.comfy.org') ||
+        url.includes('stagingapi.comfy.org')
+      ) {
+        apiCallCount++
+        await route.fulfill({
+          status: 200,
+          contentType: 'application/json',
+          body: JSON.stringify([])
+        })
+      } else {
+        await route.continue()
+      }
+    })
+
+    await comfyPage.setup({ mockReleases: false })
+
+    // Wait a bit to ensure any potential API calls would have been made
+    await comfyPage.page.waitForTimeout(1000)
+
+    // Verify no API calls were made
+    expect(apiCallCount).toBe(0)
+  })
+
+  test('should show "What\'s New" section when notifications are enabled', async ({
+    comfyPage
+  }) => {
+    // Enable version update notifications (default behavior)
+    await comfyPage.setSetting('Comfy.Notification.ShowVersionUpdates', true)
+
+    // Mock release API with test data
+    await comfyPage.page.route('**/releases**', async (route) => {
+      const url = route.request().url()
+      if (
+        url.includes('api.comfy.org') ||
+        url.includes('stagingapi.comfy.org')
+      ) {
+        await route.fulfill({
+          status: 200,
+          contentType: 'application/json',
+          body: JSON.stringify([
+            {
+              id: 1,
+              project: 'comfyui',
+              version: 'v0.3.44',
+              attention: 'medium',
+              content: '## New Features\n\n- Added awesome feature',
+              published_at: new Date().toISOString()
+            }
+          ])
+        })
+      } else {
+        await route.continue()
+      }
+    })
+
+    await comfyPage.setup({ mockReleases: false })
+
+    // Open help center
+    const helpCenterButton = comfyPage.page.locator('.comfy-help-center-btn')
+    await helpCenterButton.waitFor({ state: 'visible' })
+    await helpCenterButton.click()
+
+    // Verify help center menu appears
+    const helpMenu = comfyPage.page.locator('.help-center-menu')
+    await expect(helpMenu).toBeVisible()
+
+    // Verify "What's New?" section is visible
+    const whatsNewSection = comfyPage.page.locator('.whats-new-section')
+    await expect(whatsNewSection).toBeVisible()
+
+    // Should show the release
+    await expect(
+      whatsNewSection.locator('text=Comfy v0.3.44 Release')
+    ).toBeVisible()
+  })
+
+  test('should toggle "What\'s New" section when setting changes', async ({
+    comfyPage
+  }) => {
+    // Mock release API with test data
+    await comfyPage.page.route('**/releases**', async (route) => {
+      const url = route.request().url()
+      if (
+        url.includes('api.comfy.org') ||
+        url.includes('stagingapi.comfy.org')
+      ) {
+        await route.fulfill({
+          status: 200,
+          contentType: 'application/json',
+          body: JSON.stringify([
+            {
+              id: 1,
+              project: 'comfyui',
+              version: 'v0.3.44',
+              attention: 'low',
+              content: '## Bug Fixes\n\n- Fixed minor issue',
+              published_at: new Date().toISOString()
+            }
+          ])
+        })
+      } else {
+        await route.continue()
+      }
+    })
+
+    // Start with notifications enabled
+    await comfyPage.setSetting('Comfy.Notification.ShowVersionUpdates', true)
+    await comfyPage.setup({ mockReleases: false })
+
+    // Open help center
+    const helpCenterButton = comfyPage.page.locator('.comfy-help-center-btn')
+    await helpCenterButton.waitFor({ state: 'visible' })
+    await helpCenterButton.click()
+
+    // Verify "What's New?" section is visible
+    const whatsNewSection = comfyPage.page.locator('.whats-new-section')
+    await expect(whatsNewSection).toBeVisible()
+
+    // Close help center
+    await comfyPage.page.click('.help-center-backdrop')
+
+    // Disable notifications
+    await comfyPage.setSetting('Comfy.Notification.ShowVersionUpdates', false)
+
+    // Reopen help center
+    await helpCenterButton.click()
+
+    // Verify "What's New?" section is now hidden
+    await expect(whatsNewSection).not.toBeVisible()
+  })
+
+  test('should handle edge case with empty releases and disabled notifications', async ({
+    comfyPage
+  }) => {
+    // Disable notifications
+    await comfyPage.setSetting('Comfy.Notification.ShowVersionUpdates', false)
+
+    // Mock empty releases
+    await comfyPage.page.route('**/releases**', async (route) => {
+      const url = route.request().url()
+      if (
+        url.includes('api.comfy.org') ||
+        url.includes('stagingapi.comfy.org')
+      ) {
+        await route.fulfill({
+          status: 200,
+          contentType: 'application/json',
+          body: JSON.stringify([])
+        })
+      } else {
+        await route.continue()
+      }
+    })
+
+    await comfyPage.setup({ mockReleases: false })
+
+    // Open help center
+    const helpCenterButton = comfyPage.page.locator('.comfy-help-center-btn')
+    await helpCenterButton.waitFor({ state: 'visible' })
+    await helpCenterButton.click()
+
+    // Verify help center still works
+    const helpMenu = comfyPage.page.locator('.help-center-menu')
+    await expect(helpMenu).toBeVisible()
+
+    // Section should be hidden regardless of empty releases
+    const whatsNewSection = comfyPage.page.locator('.whats-new-section')
+    await expect(whatsNewSection).not.toBeVisible()
+  })
 })