From 6f52357f2a5ea009543bfd0b7960083cc30ab9c6 Mon Sep 17 00:00:00 2001 From: Benjamin Lu Date: Sat, 13 Dec 2025 19:47:04 -0800 Subject: [PATCH] Minor dry nit --- src/components/queue/job/QueueJobItem.vue | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/components/queue/job/QueueJobItem.vue b/src/components/queue/job/QueueJobItem.vue index bc8b1bdf6f..2263b96b32 100644 --- a/src/components/queue/job/QueueJobItem.vue +++ b/src/components/queue/job/QueueJobItem.vue @@ -315,9 +315,9 @@ const computedShowClear = computed(() => { return props.state !== 'completed' }) -const baseActions = computed(() => { - const showMenu = props.showMenu !== undefined ? props.showMenu : true +const resolvedShowMenu = computed(() => props.showMenu ?? true) +const baseActions = computed(() => { return [ { key: 'menu', @@ -328,7 +328,7 @@ const baseActions = computed(() => { iconClass: 'icon-[lucide--more-horizontal]', ariaLabel: t('g.more'), tooltip: moreTooltipConfig.value, - isVisible: () => showMenu, + isVisible: () => resolvedShowMenu.value, onClick: (event?: MouseEvent) => { if (event) emit('menu', event) } @@ -431,7 +431,6 @@ const shouldSpin = computed( ) const onContextMenu = (event: MouseEvent) => { - const shouldShowMenu = props.showMenu !== undefined ? props.showMenu : true - if (shouldShowMenu) emit('menu', event) + if (resolvedShowMenu.value) emit('menu', event) }