From 725a0a2b890f9b8375f0c8b3ccd16f046068dd99 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Sat, 7 Mar 2026 15:08:13 -0800 Subject: [PATCH] fix: remove timeouts from error toasts so they persist until dismissed (#9543) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Remove `life` (timeout) property from all error-severity toast calls so they persist until manually dismissed, preventing users from missing important error messages. ## Changes - **What**: Removed `life` property from 86 error toast calls across 46 files. Error toasts now use PrimeVue's default behavior (no auto-dismiss). Non-error toasts (success, warn, info) are unchanged. - Also fixed a pre-existing lint issue in `TaskListPanel.vue` (`import { t } from '@/i18n'` → `useI18n()`) ## Review Focus - One conditional toast in `useMediaAssetActions.ts` intentionally keeps `life` because its severity alternates between `warn` and `error` Fixes https://www.notion.so/comfy-org/Implement-Remove-timeouts-for-all-error-toasts-31b6d73d365081cead54fddc77ae7c3d ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9543-fix-remove-timeouts-from-error-toasts-so-they-persist-until-dismissed-31c6d73d365081fa8d30f6366e9bfe38) by [Unito](https://www.unito.io) --- .../components/maintenance/TaskListPanel.vue | 11 +++++---- apps/desktop-ui/src/views/MaintenanceView.vue | 3 +-- .../src/views/MetricsConsentView.vue | 11 ++++----- .../dialog/content/ErrorDialogContent.vue | 3 +-- .../TopUpCreditsDialogContentLegacy.vue | 3 +-- .../CancelSubscriptionDialogContent.vue | 3 +-- .../helpcenter/HelpCenterMenuContent.vue | 6 ++--- .../sidebar/tabs/AssetsSidebarTab.vue | 6 ++--- src/composables/useCoreCommands.ts | 24 +++++++------------ src/core/graph/subgraph/promotionUtils.ts | 3 +-- src/extensions/core/electronAdapter.ts | 6 ++--- .../composables/useMediaAssetActions.ts | 24 +++++++------------ .../assets/utils/createAssetWidget.ts | 6 ++--- .../nodeReplacement/useNodeReplacement.ts | 3 +-- .../secrets/composables/useSecrets.test.ts | 6 ++--- .../secrets/composables/useSecrets.ts | 12 ++++------ .../workflow/core/services/workflowService.ts | 3 +-- .../composables/useWorkflowPersistenceV2.ts | 3 +-- .../ShareWorkflowDialogContent.test.ts | 3 +-- .../components/ShareWorkflowDialogContent.vue | 6 ++--- .../profile/ComfyHubCreateProfileForm.vue | 3 +-- .../useSharedWorkflowUrlLoader.test.ts | 3 +-- .../composables/useSharedWorkflowUrlLoader.ts | 6 ++--- .../composables/useTemplateUrlLoader.test.ts | 6 ++--- .../composables/useTemplateUrlLoader.ts | 6 ++--- .../SubscriptionPanelContentWorkspace.vue | 3 +-- ...criptionRequiredDialogContentWorkspace.vue | 18 +++++--------- .../TopUpCreditsDialogContentWorkspace.vue | 6 ++--- .../dialogs/CreateWorkspaceDialogContent.vue | 3 +-- .../dialogs/DeleteWorkspaceDialogContent.vue | 3 +-- .../dialogs/EditWorkspaceDialogContent.vue | 3 +-- .../dialogs/InviteMemberDialogContent.vue | 6 ++--- .../dialogs/LeaveWorkspaceDialogContent.vue | 3 +-- .../dialogs/RemoveMemberDialogContent.vue | 3 +-- .../dialogs/RevokeInviteDialogContent.vue | 3 +-- .../dialogs/settings/MembersPanelContent.vue | 3 +-- .../composables/useInviteUrlLoader.test.ts | 6 ++--- .../composables/useInviteUrlLoader.ts | 3 +-- .../stores/billingOperationStore.test.ts | 12 ++++------ .../workspace/stores/billingOperationStore.ts | 6 ++--- .../extensions/vueNodes/VideoPreview.vue | 1 - .../vueNodes/components/ImagePreview.vue | 1 - .../components/audio/AudioPreviewPlayer.vue | 3 +-- src/scripts/api.ts | 6 ++--- src/stores/subgraphStore.ts | 3 +-- .../manager/composables/useManagerState.ts | 6 ++--- 46 files changed, 93 insertions(+), 177 deletions(-) diff --git a/apps/desktop-ui/src/components/maintenance/TaskListPanel.vue b/apps/desktop-ui/src/components/maintenance/TaskListPanel.vue index 2d8fd74849..5021aa0a15 100644 --- a/apps/desktop-ui/src/components/maintenance/TaskListPanel.vue +++ b/apps/desktop-ui/src/components/maintenance/TaskListPanel.vue @@ -4,7 +4,7 @@ @@ -25,7 +25,7 @@