Devex: Linter updates (#7309)

## Summary Updates for the linter/formatter deps, turning on some more rules. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7309-WIP-Linter-updates-2c56d73d36508101b3ece6bcaf7e5212) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org>
2026-03-12 08:30:08 +00:00 · 2025-12-10 11:08:47 -08:00
parent b52b2bbc30
commit 72b5444d5a
62 changed files with 1331 additions and 766 deletions
--- a/src/components/bottomPanel/tabs/shortcuts/ShortcutsList.vue
+++ b/src/components/bottomPanel/tabs/shortcuts/ShortcutsList.vue
@@ -55,7 +55,6 @@ import { normalizeI18nKey } from '@/utils/formatUtil'
 const { t } = useI18n()

 const { subcategories } = defineProps<{
-  commands: ComfyCommandImpl[]
  subcategories: Record<string, ComfyCommandImpl[]>
 }>()

--- a/src/components/breadcrumb/SubgraphBreadcrumbItem.vue
+++ b/src/components/breadcrumb/SubgraphBreadcrumbItem.vue
@@ -21,7 +21,7 @@
      class="icon-[lucide--triangle-alert] text-warning-background"
    />
    <span class="p-breadcrumb-item-label px-2">{{ item.label }}</span>
-    <Tag v-if="item.isBlueprint" :value="'Blueprint'" severity="primary" />
+    <Tag v-if="item.isBlueprint" value="Blueprint" severity="primary" />
    <i v-if="isActive" class="pi pi-angle-down text-[10px]"></i>
  </a>
  <Menu
--- a/src/components/common/EditableText.vue
+++ b/src/components/common/EditableText.vue
@@ -41,7 +41,7 @@ const {
  inputAttrs?: Record<string, string>
 }>()

-const emit = defineEmits(['update:modelValue', 'edit', 'cancel'])
+const emit = defineEmits(['edit', 'cancel'])
 const inputValue = ref<string>(modelValue)
 const inputRef = ref<InstanceType<typeof InputText> | undefined>()
 const isCanceling = ref(false)
--- a/src/components/common/FormColorPicker.vue
+++ b/src/components/common/FormColorPicker.vue
@@ -11,7 +11,6 @@ import InputText from 'primevue/inputtext'

 const modelValue = defineModel<string>('modelValue')
 defineProps<{
-  defaultValue?: string
  label?: string
 }>()

--- a/src/components/dialog/content/ErrorDialogContent.vue
+++ b/src/components/dialog/content/ErrorDialogContent.vue
@@ -5,7 +5,7 @@
      icon="pi pi-exclamation-circle"
      :title="title"
      :message="error.exceptionMessage"
-      :text-class="'break-words max-w-[60vw]'"
+      text-class="break-words max-w-[60vw]"
    />
    <template v-if="error.extensionFile">
      <span>{{ t('errorDialog.extensionFileHint') }}:</span>
--- a/src/components/graph/GraphCanvas.vue
+++ b/src/components/graph/GraphCanvas.vue
@@ -465,9 +465,8 @@ onMounted(async () => {
  await workflowPersistence.loadTemplateFromUrlIfPresent()

  // Initialize release store to fetch releases from comfy-api (fire-and-forget)
-  const { useReleaseStore } = await import(
-    '@/platform/updates/common/releaseStore'
-  )
+  const { useReleaseStore } =
+    await import('@/platform/updates/common/releaseStore')
  const releaseStore = useReleaseStore()
  void releaseStore.initialize()

--- a/src/components/graph/GraphCanvasMenu.vue
+++ b/src/components/graph/GraphCanvasMenu.vue
@@ -37,7 +37,6 @@
      </Button>

      <Button
-        ref="zoomButton"
        v-tooltip.top="t('zoomControls.label')"
        severity="secondary"
        :label="t('zoomControls.label')"
@@ -56,7 +55,6 @@
      <div class="h-[27px] w-[1px] self-center bg-node-divider" />

      <Button
-        ref="minimapButton"
        v-tooltip.top="minimapTooltip"
        severity="secondary"
        :aria-label="minimapTooltip"
--- a/src/components/graph/selectionToolbox/NodeOptions.vue
+++ b/src/components/graph/selectionToolbox/NodeOptions.vue
@@ -2,7 +2,7 @@
  <div>
    <Popover
      ref="popover"
-      :append-to="'body'"
+      append-to="body"
      :auto-z-index="true"
      :base-z-index="1000"
      :dismissable="true"
--- a/src/components/graph/widgets/TextPreviewWidget.vue
+++ b/src/components/graph/widgets/TextPreviewWidget.vue
@@ -21,7 +21,6 @@ import { linkifyHtml, nl2br } from '@/utils/formatUtil'

 const modelValue = defineModel<string>({ required: true })
 const props = defineProps<{
-  widget?: object
  nodeId: NodeId
 }>()

--- a/src/components/load3d/Load3DControls.vue
+++ b/src/components/load3d/Load3DControls.vue
@@ -35,7 +35,6 @@
    <div v-show="activeCategory" class="rounded-lg bg-smoke-700/30">
      <SceneControls
        v-if="showSceneControls"
-        ref="sceneControlsRef"
        v-model:show-grid="sceneConfig!.showGrid"
        v-model:background-color="sceneConfig!.backgroundColor"
        v-model:background-image="sceneConfig!.backgroundImage"
@@ -46,28 +45,24 @@

      <ModelControls
        v-if="showModelControls"
-        ref="modelControlsRef"
        v-model:material-mode="modelConfig!.materialMode"
        v-model:up-direction="modelConfig!.upDirection"
      />

      <CameraControls
        v-if="showCameraControls"
-        ref="cameraControlsRef"
        v-model:camera-type="cameraConfig!.cameraType"
        v-model:fov="cameraConfig!.fov"
      />

      <LightControls
        v-if="showLightControls"
-        ref="lightControlsRef"
        v-model:light-intensity="lightConfig!.intensity"
        v-model:material-mode="modelConfig!.materialMode"
      />

      <ExportControls
        v-if="showExportControls"
-        ref="exportControlsRef"
        @export-model="handleExportModel"
      />
    </div>
--- a/src/components/queue/CompletionSummaryBanner.vue
+++ b/src/components/queue/CompletionSummaryBanner.vue
@@ -9,8 +9,7 @@
    <span class="inline-flex items-center gap-2">
      <span v-if="props.mode === 'allFailed'" class="inline-flex items-center">
        <i
-          class="ml-1 icon-[lucide--circle-alert] block size-4 leading-none"
-          :class="'text-destructive-background'"
+          class="ml-1 icon-[lucide--circle-alert] block size-4 leading-none text-destructive-background"
        />
      </span>

--- a/src/components/queue/job/QueueJobItem.stories.ts
+++ b/src/components/queue/job/QueueJobItem.stories.ts
@@ -64,8 +64,7 @@ export const RunningWithCurrent: Story = {
    state: 'running',
    title: 'Generating image',
    progressTotalPercent: 66,
-    progressCurrentPercent: 10,
-    runningNodeName: 'KSampler'
+    progressCurrentPercent: 10
  }
 }

--- a/src/components/queue/job/QueueJobItem.vue
+++ b/src/components/queue/job/QueueJobItem.vue
@@ -225,7 +225,6 @@ const props = withDefaults(
    showMenu?: boolean
    progressTotalPercent?: number
    progressCurrentPercent?: number
-    runningNodeName?: string
    activeDetailsId?: string | null
  }>(),
  {
--- a/src/components/rightSidePanel/subgraph/SubgraphNodeWidget.vue
+++ b/src/components/rightSidePanel/subgraph/SubgraphNodeWidget.vue
@@ -7,7 +7,6 @@ import type { ClassValue } from '@/utils/tailwindUtil'
 const props = defineProps<{
  nodeTitle: string
  widgetName: string
-  isShown?: boolean
  isDraggable?: boolean
  isPhysical?: boolean
  class?: ClassValue
--- a/src/components/searchbox/NodeSearchBox.vue
+++ b/src/components/searchbox/NodeSearchBox.vue
@@ -49,7 +49,7 @@
      auto-option-focus
      force-selection
      multiple
-      :option-label="'display_name'"
+      option-label="display_name"
      @complete="search($event.query)"
      @option-select="onAddNode($event.value)"
      @focused-option-changed="setHoverSuggestion($event)"
--- a/src/components/topbar/WorkflowTab.vue
+++ b/src/components/topbar/WorkflowTab.vue
@@ -59,7 +59,6 @@ interface WorkflowOption {
 }

 const props = defineProps<{
-  class?: string
  workflowOption: WorkflowOption
 }>()

--- a/src/components/ui/slider/Slider.vue
+++ b/src/components/ui/slider/Slider.vue
@@ -14,6 +14,7 @@ import type { HTMLAttributes } from 'vue'
 import { cn } from '@/utils/tailwindUtil'

 const props = defineProps<
+  // eslint-disable-next-line vue/no-unused-properties
  SliderRootProps & { class?: HTMLAttributes['class'] }
 >()