Devex: Linter updates (#7309)

## Summary Updates for the linter/formatter deps, turning on some more rules. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7309-WIP-Linter-updates-2c56d73d36508101b3ece6bcaf7e5212) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org>
2026-04-28 18:22:40 +00:00 · 2025-12-10 11:08:47 -08:00
parent b52b2bbc30
commit 72b5444d5a
62 changed files with 1331 additions and 766 deletions
--- a/tests-ui/tests/components/bottomPanel/EssentialsPanel.test.ts
+++ b/tests-ui/tests/components/bottomPanel/EssentialsPanel.test.ts
@@ -61,13 +61,6 @@ describe('EssentialsPanel', () => {

    const shortcutsList = wrapper.findComponent(ShortcutsList)
    expect(shortcutsList.exists()).toBe(true)
-
-    // Should pass only essentials commands
-    const commands = shortcutsList.props('commands')
-    expect(commands).toHaveLength(3)
-    commands.forEach((cmd: ComfyCommandImpl) => {
-      expect(cmd.category).toBe('essentials')
-    })
  })

  it('should categorize commands into subcategories', () => {
--- a/tests-ui/tests/composables/useConflictAcknowledgment.test.ts
+++ b/tests-ui/tests/composables/useConflictAcknowledgment.test.ts
@@ -18,9 +18,8 @@ describe('useConflictAcknowledgment', () => {
  describe('initial state loading', () => {
    it('should load empty state when localStorage is empty', async () => {
      vi.resetModules()
-      const { useConflictAcknowledgment } = await import(
-        '@/workbench/extensions/manager/composables/useConflictAcknowledgment'
-      )
+      const { useConflictAcknowledgment } =
+        await import('@/workbench/extensions/manager/composables/useConflictAcknowledgment')
      const { acknowledgmentState } = useConflictAcknowledgment()

      expect(acknowledgmentState.value).toEqual({
@@ -44,9 +43,8 @@ describe('useConflictAcknowledgment', () => {

      // Need to import the module after localStorage is set
      vi.resetModules()
-      const { useConflictAcknowledgment } = await import(
-        '@/workbench/extensions/manager/composables/useConflictAcknowledgment'
-      )
+      const { useConflictAcknowledgment } =
+        await import('@/workbench/extensions/manager/composables/useConflictAcknowledgment')
      const { acknowledgmentState } = useConflictAcknowledgment()

      expect(acknowledgmentState.value).toEqual({
@@ -60,9 +58,8 @@ describe('useConflictAcknowledgment', () => {
  describe('dismissal functions', () => {
    it('should mark conflicts as seen with unified function', async () => {
      vi.resetModules()
-      const { useConflictAcknowledgment } = await import(
-        '@/workbench/extensions/manager/composables/useConflictAcknowledgment'
-      )
+      const { useConflictAcknowledgment } =
+        await import('@/workbench/extensions/manager/composables/useConflictAcknowledgment')
      const { markConflictsAsSeen, acknowledgmentState } =
        useConflictAcknowledgment()

@@ -73,9 +70,8 @@ describe('useConflictAcknowledgment', () => {

    it('should dismiss red dot notification', async () => {
      vi.resetModules()
-      const { useConflictAcknowledgment } = await import(
-        '@/workbench/extensions/manager/composables/useConflictAcknowledgment'
-      )
+      const { useConflictAcknowledgment } =
+        await import('@/workbench/extensions/manager/composables/useConflictAcknowledgment')
      const { dismissRedDotNotification, acknowledgmentState } =
        useConflictAcknowledgment()

@@ -86,9 +82,8 @@ describe('useConflictAcknowledgment', () => {

    it('should dismiss warning banner', async () => {
      vi.resetModules()
-      const { useConflictAcknowledgment } = await import(
-        '@/workbench/extensions/manager/composables/useConflictAcknowledgment'
-      )
+      const { useConflictAcknowledgment } =
+        await import('@/workbench/extensions/manager/composables/useConflictAcknowledgment')
      const { dismissWarningBanner, acknowledgmentState } =
        useConflictAcknowledgment()

@@ -99,9 +94,8 @@ describe('useConflictAcknowledgment', () => {

    it('should mark all conflicts as seen', async () => {
      vi.resetModules()
-      const { useConflictAcknowledgment } = await import(
-        '@/workbench/extensions/manager/composables/useConflictAcknowledgment'
-      )
+      const { useConflictAcknowledgment } =
+        await import('@/workbench/extensions/manager/composables/useConflictAcknowledgment')
      const { markConflictsAsSeen, acknowledgmentState } =
        useConflictAcknowledgment()

@@ -117,9 +111,8 @@ describe('useConflictAcknowledgment', () => {
    it('should calculate shouldShowConflictModal correctly', async () => {
      // Need fresh module import to ensure clean state
      vi.resetModules()
-      const { useConflictAcknowledgment } = await import(
-        '@/workbench/extensions/manager/composables/useConflictAcknowledgment'
-      )
+      const { useConflictAcknowledgment } =
+        await import('@/workbench/extensions/manager/composables/useConflictAcknowledgment')
      const { shouldShowConflictModal, markConflictsAsSeen } =
        useConflictAcknowledgment()

@@ -131,9 +124,8 @@ describe('useConflictAcknowledgment', () => {

    it('should calculate shouldShowRedDot correctly based on conflicts', async () => {
      vi.resetModules()
-      const { useConflictAcknowledgment } = await import(
-        '@/workbench/extensions/manager/composables/useConflictAcknowledgment'
-      )
+      const { useConflictAcknowledgment } =
+        await import('@/workbench/extensions/manager/composables/useConflictAcknowledgment')
      const { shouldShowRedDot, dismissRedDotNotification } =
        useConflictAcknowledgment()

@@ -146,9 +138,8 @@ describe('useConflictAcknowledgment', () => {

    it('should calculate shouldShowManagerBanner correctly', async () => {
      vi.resetModules()
-      const { useConflictAcknowledgment } = await import(
-        '@/workbench/extensions/manager/composables/useConflictAcknowledgment'
-      )
+      const { useConflictAcknowledgment } =
+        await import('@/workbench/extensions/manager/composables/useConflictAcknowledgment')
      const { shouldShowManagerBanner, dismissWarningBanner } =
        useConflictAcknowledgment()

@@ -164,9 +155,8 @@ describe('useConflictAcknowledgment', () => {
    it('should persist to localStorage automatically', async () => {
      // Need fresh module import to ensure clean state
      vi.resetModules()
-      const { useConflictAcknowledgment } = await import(
-        '@/workbench/extensions/manager/composables/useConflictAcknowledgment'
-      )
+      const { useConflictAcknowledgment } =
+        await import('@/workbench/extensions/manager/composables/useConflictAcknowledgment')
      const { markConflictsAsSeen, dismissWarningBanner } =
        useConflictAcknowledgment()

--- a/tests-ui/tests/composables/useMinimap.test.ts
+++ b/tests-ui/tests/composables/useMinimap.test.ts
@@ -153,9 +153,8 @@ vi.mock('@/platform/workflow/management/stores/workflowStore', () => ({
  }))
 }))

-const { useMinimap } = await import(
-  '@/renderer/extensions/minimap/composables/useMinimap'
-)
+const { useMinimap } =
+  await import('@/renderer/extensions/minimap/composables/useMinimap')
 const { api } = await import('@/scripts/api')

 describe('useMinimap', () => {
--- a/tests-ui/tests/composables/useTemplateFiltering.test.ts
+++ b/tests-ui/tests/composables/useTemplateFiltering.test.ts
@@ -29,9 +29,8 @@ vi.mock('@/platform/telemetry', () => ({
  }))
 }))

-const { useTemplateFiltering } = await import(
-  '@/composables/useTemplateFiltering'
-)
+const { useTemplateFiltering } =
+  await import('@/composables/useTemplateFiltering')

 describe('useTemplateFiltering', () => {
  beforeEach(() => {
--- a/tests-ui/tests/renderer/extensions/minimap/composables/useMinimapRenderer.test.ts
+++ b/tests-ui/tests/renderer/extensions/minimap/composables/useMinimapRenderer.test.ts
@@ -103,9 +103,8 @@ describe('useMinimapRenderer', () => {
  })

  it('should only render when redraw is needed', async () => {
-    const { renderMinimapToCanvas } = await import(
-      '@/renderer/extensions/minimap/minimapCanvasRenderer'
-    )
+    const { renderMinimapToCanvas } =
+      await import('@/renderer/extensions/minimap/minimapCanvasRenderer')
    const canvasRef = ref(mockCanvas)
    const graphRef = ref(mockGraph as any)
    const boundsRef = ref({ minX: 0, minY: 0, width: 100, height: 100 })
--- a/tests-ui/tests/renderer/extensions/minimap/composables/useMinimapViewport.test.ts
+++ b/tests-ui/tests/renderer/extensions/minimap/composables/useMinimapViewport.test.ts
@@ -66,9 +66,8 @@ describe('useMinimapViewport', () => {
  })

  it('should calculate graph bounds from nodes', async () => {
-    const { calculateNodeBounds, enforceMinimumBounds } = await import(
-      '@/renderer/core/spatial/boundsCalculator'
-    )
+    const { calculateNodeBounds, enforceMinimumBounds } =
+      await import('@/renderer/core/spatial/boundsCalculator')

    vi.mocked(calculateNodeBounds).mockReturnValue({
      minX: 100,
@@ -93,9 +92,8 @@ describe('useMinimapViewport', () => {
  })

  it('should handle empty graph', async () => {
-    const { calculateNodeBounds } = await import(
-      '@/renderer/core/spatial/boundsCalculator'
-    )
+    const { calculateNodeBounds } =
+      await import('@/renderer/core/spatial/boundsCalculator')

    vi.mocked(calculateNodeBounds).mockReturnValue(null)

--- a/tests-ui/tests/renderer/thumbnail/composables/useWorkflowThumbnail.test.ts
+++ b/tests-ui/tests/renderer/thumbnail/composables/useWorkflowThumbnail.test.ts
@@ -19,12 +19,10 @@ vi.mock('@/scripts/api', () => ({
  }
 }))

-const { useWorkflowThumbnail } = await import(
-  '@/renderer/core/thumbnail/useWorkflowThumbnail'
-)
-const { createGraphThumbnail } = await import(
-  '@/renderer/core/thumbnail/graphThumbnailRenderer'
-)
+const { useWorkflowThumbnail } =
+  await import('@/renderer/core/thumbnail/useWorkflowThumbnail')
+const { createGraphThumbnail } =
+  await import('@/renderer/core/thumbnail/graphThumbnailRenderer')
 const { api } = await import('@/scripts/api')

 describe('useWorkflowThumbnail', () => {
--- a/tests-ui/tests/store/releaseStore.test.ts
+++ b/tests-ui/tests/store/releaseStore.test.ts
@@ -62,9 +62,8 @@ describe('useReleaseStore', () => {
    }

    // Setup mock implementations
-    const { useReleaseService } = await import(
-      '@/platform/updates/common/releaseService'
-    )
+    const { useReleaseService } =
+      await import('@/platform/updates/common/releaseService')
    const { useSettingStore } = await import('@/platform/settings/settingStore')
    const { useSystemStatsStore } = await import('@/stores/systemStatsStore')
    const { isElectron } = await import('@/utils/envUtil')
--- a/tests-ui/tests/utils/versionUtil.test.ts
+++ b/tests-ui/tests/utils/versionUtil.test.ts
@@ -287,9 +287,8 @@ describe('versionUtil', () => {
      vi.resetModules()

      // Import fresh module
-      const versionUtil = await import(
-        '@/workbench/extensions/manager/utils/versionUtil'
-      )
+      const versionUtil =
+        await import('@/workbench/extensions/manager/utils/versionUtil')

      const version = versionUtil.getFrontendVersion()
      expect(version).toBe('2.0.0')
@@ -322,9 +321,8 @@ describe('versionUtil', () => {
      vi.resetModules()

      // Import fresh module
-      const versionUtil = await import(
-        '@/workbench/extensions/manager/utils/versionUtil'
-      )
+      const versionUtil =
+        await import('@/workbench/extensions/manager/utils/versionUtil')

      const version = versionUtil.getFrontendVersion()
      expect(version).toBeUndefined()