From 73b08acfe05a79cd009cf37d5586116bcb6b30d5 Mon Sep 17 00:00:00 2001 From: Terry Jia Date: Tue, 9 Dec 2025 12:17:07 -0500 Subject: [PATCH] fix: Note/MarkdownNote node color change not reactive in vueNodes mode (#7294) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Move color/bgcolor initialization from class field overrides to constructor to preserve LGraphNodeProperties getter/setter instrumentation. Class field overrides were replacing the reactive property descriptors set by the parent constructor, preventing change events from firing. issue found while tesing in https://github.com/Comfy-Org/ComfyUI_frontend/issues/3449 ## Screenshots Before https://github.com/user-attachments/assets/04499a3a-15c2-44fd-9819-6dd5f6849f20 After https://github.com/user-attachments/assets/ba93278b-9761-4d45-abb3-2a57ff95a900 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7294-fix-Note-MarkdownNote-node-color-change-not-reactive-in-vueNodes-mode-2c46d73d3650818f8ee6f6f0c0e61d39) by [Unito](https://www.unito.io) --- src/extensions/core/noteNode.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/extensions/core/noteNode.ts b/src/extensions/core/noteNode.ts index 8b2d9ed99..7e0ec56a6 100644 --- a/src/extensions/core/noteNode.ts +++ b/src/extensions/core/noteNode.ts @@ -14,13 +14,15 @@ app.registerExtension({ static collapsable: boolean static title_mode: number - override color = LGraphCanvas.node_colors.yellow.color - override bgcolor = LGraphCanvas.node_colors.yellow.bgcolor groupcolor = LGraphCanvas.node_colors.yellow.groupcolor override isVirtualNode: boolean constructor(title: string) { super(title) + + this.color = LGraphCanvas.node_colors.yellow.color + this.bgcolor = LGraphCanvas.node_colors.yellow.bgcolor + if (!this.properties) { this.properties = { text: '' } } @@ -53,12 +55,14 @@ app.registerExtension({ class MarkdownNoteNode extends LGraphNode { static override title = 'Markdown Note' - override color = LGraphCanvas.node_colors.yellow.color - override bgcolor = LGraphCanvas.node_colors.yellow.bgcolor groupcolor = LGraphCanvas.node_colors.yellow.groupcolor constructor(title: string) { super(title) + + this.color = LGraphCanvas.node_colors.yellow.color + this.bgcolor = LGraphCanvas.node_colors.yellow.bgcolor + if (!this.properties) { this.properties = { text: '' } }