[bugfix] Show active job count in assets sidebar badge (#9015)

## Summary
Assets sidebar badge now shows total active jobs (pending + running)
instead of only pending jobs, making it consistent with the "X active
jobs" label inside the panel.

## Changes
- **What**: Changed `iconBadge` in `useAssetsSidebarTab` from
`pendingTasks.length` to `activeJobsCount` (pending + running)
- Badge still hidden when QPO V2 is disabled (legacy queue)

## Review Focus
- Whether `activeJobsCount` (pending + running) is the correct metric
for the badge

<img width="1718" height="1327" alt="스크린샷 2026-02-20 오후 7 46
40(2)"
src="https://github.com/user-attachments/assets/4d0d2bed-8be9-44d7-bd62-4dd8c075d265"
/>

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-9015-bugfix-Show-active-job-count-in-assets-sidebar-badge-30d6d73d365081c287a6ce9bc0a60244)
by [Unito](https://www.unito.io)
This commit is contained in:
Jin Yi
2026-02-20 20:02:10 +09:00
committed by GitHub
parent 01f59afff2
commit 7bf9d51d1d
2 changed files with 17 additions and 9 deletions

View File

@@ -2,9 +2,9 @@ import { describe, expect, it, vi } from 'vitest'
import { useAssetsSidebarTab } from '@/composables/sidebarTabs/useAssetsSidebarTab' import { useAssetsSidebarTab } from '@/composables/sidebarTabs/useAssetsSidebarTab'
const { mockGetSetting, mockPendingTasks } = vi.hoisted(() => ({ const { mockGetSetting, mockActiveJobsCount } = vi.hoisted(() => ({
mockGetSetting: vi.fn(), mockGetSetting: vi.fn(),
mockPendingTasks: [] as unknown[] mockActiveJobsCount: { value: 0 }
})) }))
vi.mock('@/platform/settings/settingStore', () => ({ vi.mock('@/platform/settings/settingStore', () => ({
@@ -19,14 +19,14 @@ vi.mock('@/components/sidebar/tabs/AssetsSidebarTab.vue', () => ({
vi.mock('@/stores/queueStore', () => ({ vi.mock('@/stores/queueStore', () => ({
useQueueStore: () => ({ useQueueStore: () => ({
pendingTasks: mockPendingTasks activeJobsCount: mockActiveJobsCount.value
}) })
})) }))
describe('useAssetsSidebarTab', () => { describe('useAssetsSidebarTab', () => {
it('hides icon badge when QPO V2 is disabled', () => { it('hides icon badge when QPO V2 is disabled', () => {
mockGetSetting.mockReturnValue(false) mockGetSetting.mockReturnValue(false)
mockPendingTasks.splice(0, mockPendingTasks.length, {}, {}) mockActiveJobsCount.value = 3
const sidebarTab = useAssetsSidebarTab() const sidebarTab = useAssetsSidebarTab()
@@ -34,13 +34,22 @@ describe('useAssetsSidebarTab', () => {
expect((sidebarTab.iconBadge as () => string | null)()).toBeNull() expect((sidebarTab.iconBadge as () => string | null)()).toBeNull()
}) })
it('shows pending task count when QPO V2 is enabled', () => { it('shows active job count when QPO V2 is enabled', () => {
mockGetSetting.mockReturnValue(true) mockGetSetting.mockReturnValue(true)
mockPendingTasks.splice(0, mockPendingTasks.length, {}, {}, {}) mockActiveJobsCount.value = 3
const sidebarTab = useAssetsSidebarTab() const sidebarTab = useAssetsSidebarTab()
expect(typeof sidebarTab.iconBadge).toBe('function') expect(typeof sidebarTab.iconBadge).toBe('function')
expect((sidebarTab.iconBadge as () => string | null)()).toBe('3') expect((sidebarTab.iconBadge as () => string | null)()).toBe('3')
}) })
it('hides badge when no active jobs', () => {
mockGetSetting.mockReturnValue(true)
mockActiveJobsCount.value = 0
const sidebarTab = useAssetsSidebarTab()
expect((sidebarTab.iconBadge as () => string | null)()).toBeNull()
})
}) })

View File

@@ -22,9 +22,8 @@ export const useAssetsSidebarTab = (): SidebarTabExtension => {
} }
const queueStore = useQueueStore() const queueStore = useQueueStore()
return queueStore.pendingTasks.length > 0 const count = queueStore.activeJobsCount
? queueStore.pendingTasks.length.toString() return count > 0 ? count.toString() : null
: null
} }
} }
} }