mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-28 18:22:40 +00:00
Flaky tests and observable state (#1526)
* Fix missing await * Fix flaky tests - keyboard combos Old code is causing playwright &/ changeTracker to add an undo step. Using combo mode resolves flakiness until that can be investigated thoroughly. * Restore skipped tests * Fix flaky tests * Async clean up * Fix test always fails on retry * Add TS types (tests) * Fix flaky test * Add observable busy state to workflow store * Add workflow store busy wait to tests * Rename test for clarity * Fix flaky tests - use press() from locator API Ref: https://playwright.dev/docs/api/class-keyboard#keyboard-press * Fix flaky test - wait next frame * Add delay between mouse events Litegraph pointer handling is all custom coded, so a adding a delay between events for a bit of reality is actually beneficial.
This commit is contained in:
@@ -504,6 +504,7 @@ test.describe('Menu', () => {
|
||||
await comfyPage.menu.topbar.saveWorkflow(workflowName)
|
||||
expect(await comfyPage.menu.topbar.getTabNames()).toEqual([workflowName])
|
||||
await comfyPage.menu.topbar.closeWorkflowTab(workflowName)
|
||||
await comfyPage.nextFrame()
|
||||
expect(await comfyPage.menu.topbar.getTabNames()).toEqual([
|
||||
'Unsaved Workflow'
|
||||
])
|
||||
@@ -525,8 +526,7 @@ test.describe('Menu', () => {
|
||||
})
|
||||
|
||||
test('Displays keybinding next to item', async ({ comfyPage }) => {
|
||||
const workflowMenuItem =
|
||||
await comfyPage.menu.topbar.getMenuItem('Workflow')
|
||||
const workflowMenuItem = comfyPage.menu.topbar.getMenuItem('Workflow')
|
||||
await workflowMenuItem.click()
|
||||
const exportTag = comfyPage.page.locator('.keybinding-tag', {
|
||||
hasText: 'Ctrl + s'
|
||||
|
||||
Reference in New Issue
Block a user