From 7ea9a8405df9702c8987cfbdc703d14b3faba1e9 Mon Sep 17 00:00:00 2001
From: Chenlei Hu <huchenlei@proton.me>
Date: Mon, 3 Feb 2025 21:33:19 -0800
Subject: [PATCH] [Reland][Refactor] Move node title background draw logic to
 LGraphNode  (#459)

* [Refactor] Move node title background draw logic to LGraphNode (#452)

* Fix collapsed
---
 src/LGraphCanvas.ts | 34 +++----------------------
 src/LGraphNode.ts   | 62 +++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+), 30 deletions(-)

diff --git a/src/LGraphCanvas.ts b/src/LGraphCanvas.ts
index 43e768364..e71f99035 100644
--- a/src/LGraphCanvas.ts
+++ b/src/LGraphCanvas.ts
@@ -5175,36 +5175,10 @@ export class LGraphCanvas {
 
     // Title bar background (remember, it is rendered ABOVE the node)
     if (render_title || title_mode == TitleMode.TRANSPARENT_TITLE) {
-      if (node.onDrawTitleBar) {
-        node.onDrawTitleBar(ctx, title_height, size, this.ds.scale, fgcolor)
-      } else if (
-        title_mode !== TitleMode.TRANSPARENT_TITLE
-      ) {
-        const title_color = node.constructor.title_color || fgcolor
-
-        if (collapsed) {
-          ctx.shadowColor = LiteGraph.DEFAULT_SHADOW_COLOR
-        }
-
-        ctx.fillStyle = title_color
-        ctx.beginPath()
-
-        if (shape == RenderShape.BOX || low_quality) {
-          ctx.rect(0, -title_height, size[0], title_height)
-        } else if (shape == RenderShape.ROUND || shape == RenderShape.CARD) {
-          ctx.roundRect(
-            0,
-            -title_height,
-            size[0],
-            title_height,
-            collapsed
-              ? [LiteGraph.ROUND_RADIUS]
-              : [LiteGraph.ROUND_RADIUS, LiteGraph.ROUND_RADIUS, 0, 0],
-          )
-        }
-        ctx.fill()
-        ctx.shadowColor = "transparent"
-      }
+      node.drawTitleBarBackground(ctx, {
+        scale: this.ds.scale,
+        low_quality,
+      })
 
       // title box
       const box_size = 10
diff --git a/src/LGraphNode.ts b/src/LGraphNode.ts
index 0f82aefea..4650484eb 100644
--- a/src/LGraphNode.ts
+++ b/src/LGraphNode.ts
@@ -223,6 +223,10 @@ export class LGraphNode implements Positionable, IPinnable {
   badgePosition: BadgePosition = BadgePosition.TopLeft
   onOutputRemoved?(this: LGraphNode, slot: number): void
   onInputRemoved?(this: LGraphNode, slot: number, input: INodeInputSlot): void
+  /**
+   * The width of the node when collapsed.
+   * Updated by {@link LGraphCanvas.drawNode}
+   */
   _collapsed_width: number
   /** Called once at the start of every frame.  Caller may change the values in {@link out}, which will be reflected in {@link boundingRect}. */
   onBounding?(this: LGraphNode, out: Rect): void
@@ -295,6 +299,13 @@ export class LGraphNode implements Positionable, IPinnable {
     this._size[1] = value[1]
   }
 
+  /**
+   * The size of the node used for rendering.
+   */
+  get renderingSize(): Size {
+    return this.flags.collapsed ? [this._collapsed_width, 0] : this._size
+  }
+
   get shape(): RenderShape {
     return this._shape
   }
@@ -2798,6 +2809,57 @@ export class LGraphNode implements Positionable, IPinnable {
     }
   }
 
+  /**
+   * Renders the node's title bar background
+   */
+  drawTitleBarBackground(ctx: CanvasRenderingContext2D, options: {
+    scale: number
+    title_height?: number
+    low_quality?: boolean
+  }): void {
+    const {
+      scale,
+      title_height = LiteGraph.NODE_TITLE_HEIGHT,
+      low_quality = false,
+    } = options
+
+    const fgcolor = this.renderingColor
+    const shape = this.renderingShape
+    const size = this.renderingSize
+
+    if (this.onDrawTitleBar) {
+      this.onDrawTitleBar(ctx, title_height, size, scale, fgcolor)
+      return
+    }
+
+    if (this.title_mode === TitleMode.TRANSPARENT_TITLE) {
+      return
+    }
+
+    if (this.collapsed) {
+      ctx.shadowColor = LiteGraph.DEFAULT_SHADOW_COLOR
+    }
+
+    ctx.fillStyle = this.constructor.title_color || fgcolor
+    ctx.beginPath()
+
+    if (shape == RenderShape.BOX || low_quality) {
+      ctx.rect(0, -title_height, size[0], title_height)
+    } else if (shape == RenderShape.ROUND || shape == RenderShape.CARD) {
+      ctx.roundRect(
+        0,
+        -title_height,
+        size[0],
+        title_height,
+        this.collapsed
+          ? [LiteGraph.ROUND_RADIUS]
+          : [LiteGraph.ROUND_RADIUS, LiteGraph.ROUND_RADIUS, 0, 0],
+      )
+    }
+    ctx.fill()
+    ctx.shadowColor = "transparent"
+  }
+
   /**
    * Attempts to gracefully bypass this node in all of its connections by reconnecting all links.
    *