From 7f60811ebfd7f0161a65794fb7e70b64e2314932 Mon Sep 17 00:00:00 2001 From: filtered <176114999+webfiltered@users.noreply.github.com> Date: Wed, 18 Dec 2024 04:47:09 +1100 Subject: [PATCH] Fix cannot open groupNodes menu from canvas (#1925) * Fix cannot open groupNode menu from canvas * Fix cannot open groupNode menu from canvas Fixes root cause of issue * Update locales [skip ci] --------- Co-authored-by: github-actions --- src/extensions/core/groupNode.ts | 2 +- src/extensions/core/groupNodeManage.ts | 5 +++-- src/locales/en/main.json | 2 +- src/locales/en/nodeDefs.json | 17 +++++++++++++++++ src/locales/ja/nodeDefs.json | 17 +++++++++++++++++ src/locales/ko/nodeDefs.json | 17 +++++++++++++++++ src/locales/ru/nodeDefs.json | 17 +++++++++++++++++ src/locales/zh/nodeDefs.json | 17 +++++++++++++++++ 8 files changed, 90 insertions(+), 4 deletions(-) diff --git a/src/extensions/core/groupNode.ts b/src/extensions/core/groupNode.ts index e6c739519..b47130e8b 100644 --- a/src/extensions/core/groupNode.ts +++ b/src/extensions/core/groupNode.ts @@ -1425,7 +1425,7 @@ function addConvertToGroupOptions() { options.splice(index + 1, null, { content: `Manage Group Nodes`, disabled, - callback: manageGroupNodes + callback: () => manageGroupNodes() }) } diff --git a/src/extensions/core/groupNodeManage.ts b/src/extensions/core/groupNodeManage.ts index d845bd4e4..00abd14bb 100644 --- a/src/extensions/core/groupNodeManage.ts +++ b/src/extensions/core/groupNodeManage.ts @@ -373,7 +373,7 @@ export class ManageGroupDialog extends ComfyDialog { groupNodes.map((g) => $el('option', { textContent: g, - selected: `${PREFIX}${SEPARATOR}` + g === type, + selected: `${PREFIX}${SEPARATOR}${g}` === type, value: g }) ) @@ -512,7 +512,8 @@ export class ManageGroupDialog extends ComfyDialog { this.element.replaceChildren(outer) this.changeGroup( type - ? groupNodes.find((g) => `${PREFIX}${SEPARATOR}` + g === type) + ? groupNodes.find((g) => `${PREFIX}${SEPARATOR}${g}` === type) ?? + groupNodes[0] : groupNodes[0] ) this.element.showModal() diff --git a/src/locales/en/main.json b/src/locales/en/main.json index eedefd36c..ad1148285 100644 --- a/src/locales/en/main.json +++ b/src/locales/en/main.json @@ -909,8 +909,8 @@ "DevTools": "DevTools", "deprecated": "deprecated", "latent": "latent", - "audio": "audio", "video": "video", + "audio": "audio", "ltxv": "ltxv", "sd3": "sd3", "sigmas": "sigmas", diff --git a/src/locales/en/nodeDefs.json b/src/locales/en/nodeDefs.json index ede09b391..6fcbdf745 100644 --- a/src/locales/en/nodeDefs.json +++ b/src/locales/en/nodeDefs.json @@ -1157,6 +1157,23 @@ } } }, + "EmptyHunyuanLatentVideo": { + "display_name": "EmptyHunyuanLatentVideo", + "inputs": { + "width": { + "name": "width" + }, + "height": { + "name": "height" + }, + "length": { + "name": "length" + }, + "batch_size": { + "name": "batch_size" + } + } + }, "EmptyImage": { "display_name": "EmptyImage", "inputs": { diff --git a/src/locales/ja/nodeDefs.json b/src/locales/ja/nodeDefs.json index 192be216e..c310e2f98 100644 --- a/src/locales/ja/nodeDefs.json +++ b/src/locales/ja/nodeDefs.json @@ -1157,6 +1157,23 @@ } } }, + "EmptyHunyuanLatentVideo": { + "display_name": "EmptyHunyuanLatentVideo", + "inputs": { + "batch_size": { + "name": "バッチサイズ" + }, + "height": { + "name": "高さ" + }, + "length": { + "name": "長さ" + }, + "width": { + "name": "幅" + } + } + }, "EmptyImage": { "display_name": "空の画像", "inputs": { diff --git a/src/locales/ko/nodeDefs.json b/src/locales/ko/nodeDefs.json index a5839d96e..b576b868f 100644 --- a/src/locales/ko/nodeDefs.json +++ b/src/locales/ko/nodeDefs.json @@ -1157,6 +1157,23 @@ } } }, + "EmptyHunyuanLatentVideo": { + "display_name": "EmptyHunyuanLatentVideo", + "inputs": { + "batch_size": { + "name": "배치 크기" + }, + "height": { + "name": "높이" + }, + "length": { + "name": "길이" + }, + "width": { + "name": "너비" + } + } + }, "EmptyImage": { "display_name": "빈 이미지", "inputs": { diff --git a/src/locales/ru/nodeDefs.json b/src/locales/ru/nodeDefs.json index e63550e17..1d858bbf2 100644 --- a/src/locales/ru/nodeDefs.json +++ b/src/locales/ru/nodeDefs.json @@ -1157,6 +1157,23 @@ } } }, + "EmptyHunyuanLatentVideo": { + "display_name": "ПустойHunyuanLatentVideo", + "inputs": { + "batch_size": { + "name": "размер_пакета" + }, + "height": { + "name": "высота" + }, + "length": { + "name": "длина" + }, + "width": { + "name": "ширина" + } + } + }, "EmptyImage": { "display_name": "Пустое изображение", "inputs": { diff --git a/src/locales/zh/nodeDefs.json b/src/locales/zh/nodeDefs.json index 78fbb88d7..04d605a73 100644 --- a/src/locales/zh/nodeDefs.json +++ b/src/locales/zh/nodeDefs.json @@ -1157,6 +1157,23 @@ } } }, + "EmptyHunyuanLatentVideo": { + "display_name": "空的混元潜在视频", + "inputs": { + "batch_size": { + "name": "批量大小" + }, + "height": { + "name": "高度" + }, + "length": { + "name": "长度" + }, + "width": { + "name": "宽度" + } + } + }, "EmptyImage": { "display_name": "空图像", "inputs": {