From 81401c61f30f96594e06e18d5d602e6a11081cfd Mon Sep 17 00:00:00 2001 From: ComfyPRBot Date: Mon, 22 Dec 2025 20:22:58 +0000 Subject: [PATCH] fix: resolve shellcheck warnings in playwright deployment script - Replace sed with bash parameter expansion for /index.html removal (SC2001) - Remove unused trace_link variable (SC2034) --- scripts/cicd/pr-playwright-deploy-and-comment.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/cicd/pr-playwright-deploy-and-comment.sh b/scripts/cicd/pr-playwright-deploy-and-comment.sh index 2a060f1fd5..ad7c1eede2 100755 --- a/scripts/cicd/pr-playwright-deploy-and-comment.sh +++ b/scripts/cicd/pr-playwright-deploy-and-comment.sh @@ -358,14 +358,12 @@ $status_icon **$status_text** • ⏰ $(date -u '+%m/%d/%Y, %I:%M:%S %p') UTC" source_link="https://github.com/$GITHUB_REPOSITORY/blob/$BRANCH_NAME/$test_file#L$test_line" # Build trace viewer link if trace exists - trace_link="" if [ -n "$trace_path" ] && [ "$trace_path" != "null" ]; then # Extract trace filename from path trace_file=$(basename "$trace_path") url="${url_array[$i]:-}" if [ "$url" != "failed" ] && [ -n "$url" ]; then - base_url=$(echo "$url" | sed 's|/index.html||') - trace_link="${base_url}/data/${trace_file}" + base_url="${url%/index.html}" trace_viewer_link="${base_url}/trace/?trace=${base_url}/data/${trace_file}" fi fi