From 818d0ef5f6a8145045a11f080270f856b88b35fa Mon Sep 17 00:00:00 2001 From: Alexander Brown <448862+DrJKL@users.noreply.github.com> Date: Sat, 31 Jan 2026 16:33:12 -0800 Subject: [PATCH] fix: update nodeLibrary customize dialog selectors Replace getByRole('radio') with button group selectors. The Customize Folder dialog now uses PrimeVue SelectButton components instead of radio buttons. Amp-Thread-ID: https://ampcode.com/threads/T-019c1698-7c35-747e-8b78-b9d47f49c950 Co-authored-by: Amp --- .../tests/sidebar/nodeLibrary.spec.ts | 34 +++++++++++++++---- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/browser_tests/tests/sidebar/nodeLibrary.spec.ts b/browser_tests/tests/sidebar/nodeLibrary.spec.ts index 1049a236c..375a6c251 100644 --- a/browser_tests/tests/sidebar/nodeLibrary.spec.ts +++ b/browser_tests/tests/sidebar/nodeLibrary.spec.ts @@ -213,9 +213,19 @@ test.describe('Node library sidebar', () => { const tab = comfyPage.menu.nodeLibraryTab await tab.getFolder('foo').click({ button: 'right' }) await comfyPage.page.getByLabel('Customize').click() - await comfyPage.page.getByRole('radio', { name: 'Folder' }).click() - await comfyPage.page.getByRole('radio', { name: 'Blue' }).click() - await comfyPage.page.getByRole('button', { name: 'Confirm' }).click() + const dialog = comfyPage.page.getByRole('dialog', { + name: 'Customize Folder' + }) + // Select Folder icon (2nd button in Icon group) + const iconGroup = dialog.getByText('Icon').locator('..').getByRole('group') + await iconGroup.getByRole('button').nth(1).click() + // Select Blue color (2nd button in Color group) + const colorGroup = dialog + .getByText('Color') + .locator('..') + .getByRole('group') + await colorGroup.getByRole('button').nth(1).click() + await dialog.getByRole('button', { name: 'Confirm' }).click() await comfyPage.nextFrame() expect( await comfyPage.settings.getSetting( @@ -236,8 +246,13 @@ test.describe('Node library sidebar', () => { const tab = comfyPage.menu.nodeLibraryTab await tab.getFolder('foo').click({ button: 'right' }) await comfyPage.page.getByLabel('Customize').click() - await comfyPage.page.getByRole('radio', { name: 'Folder' }).click() - await comfyPage.page.getByRole('button', { name: 'Confirm' }).click() + const dialog = comfyPage.page.getByRole('dialog', { + name: 'Customize Folder' + }) + // Select Folder icon (2nd button in Icon group) + const iconGroup = dialog.getByText('Icon').locator('..').getByRole('group') + await iconGroup.getByRole('button').nth(1).click() + await dialog.getByRole('button', { name: 'Confirm' }).click() await comfyPage.nextFrame() expect( await comfyPage.settings.getSetting( @@ -276,8 +291,13 @@ test.describe('Node library sidebar', () => { await comfyPage.page.locator('.p-colorpicker-color-background').click() // Finalize the customization - await comfyPage.page.getByRole('radio', { name: 'Folder' }).click() - await comfyPage.page.getByRole('button', { name: 'Confirm' }).click() + const dialog = comfyPage.page.getByRole('dialog', { + name: 'Customize Folder' + }) + // Select Folder icon (2nd button in Icon group) + const iconGroup = dialog.getByText('Icon').locator('..').getByRole('group') + await iconGroup.getByRole('button').nth(1).click() + await dialog.getByRole('button', { name: 'Confirm' }).click() await comfyPage.nextFrame() // Verify the color selection is saved